Issue 14005007: MIPS: Disentangle field from transition stores.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14005007: MIPS: Disentangle field from transition stores. (Closed)

Created:
7 years, 8 months ago by palfia

Modified:
7 years, 8 months ago

Reviewers:
kisg, Paul Lind, kilvadyb, danno, Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Disentangle field from transition stores. Port r14223 (c6460cd6) BUG= Committed: https://code.google.com/p/v8/source/detail?r=14237

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -33 lines)			Patch
	M	src/mips/stub-cache-mips.cc	View		4 chunks	+112 lines, -33 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Lind

LGTM. The inline comment does not need a change for today. https://codereview.chromium.org/14005007/diff/1/src/mips/stub-cache-mips.cc File src/mips/stub-cache-mips.cc (right): ...

7 years, 8 months ago (2013-04-11 23:09:15 UTC) #2

Message was sent while issue was closed.

Committed manually as r14237 (presubmit successful).

Expand Messages | Collapse Messages