Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1400483002: [turbofan] Compute proper type for globals with "constant type". (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Compute proper type for globals with "constant type". For property cells with cell type kConstantType, we can compute an appropriate JavaScript type based on the current value of that cell. Numbers cannot use Type::Of here, because the type might be too precise, so we handle smi and heap number specially. R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/fd4e0dc2ce85281a3f713eee4e345525126460d7 Cr-Commit-Position: refs/heads/master@{#31171}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M src/compiler/js-global-specialization.cc View 1 chunk +10 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 2 months ago (2015-10-08 06:04:00 UTC) #1
Benedikt Meurer
Hey Jaro, Fix open TODO from initial commit. Please take a look. Thanks, Benedikt
5 years, 2 months ago (2015-10-08 06:04:48 UTC) #2
Jarin
lgtm
5 years, 2 months ago (2015-10-08 08:25:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400483002/1
5 years, 2 months ago (2015-10-08 08:49:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-08 08:59:00 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 08:59:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd4e0dc2ce85281a3f713eee4e345525126460d7
Cr-Commit-Position: refs/heads/master@{#31171}

Powered by Google App Engine
This is Rietveld 408576698