Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: packages/dart_style/test/regression/0000/0080.unit

Issue 1400473008: Roll Observatory packages and add a roll script (Closed) Base URL: git@github.com:dart-lang/observatory_pub_packages.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: packages/dart_style/test/regression/0000/0080.unit
diff --git a/packages/dart_style/test/regression/0000/0080.unit b/packages/dart_style/test/regression/0000/0080.unit
new file mode 100644
index 0000000000000000000000000000000000000000..39199d871fe1fd66cc89724f1ba9e5af09fc88d0
--- /dev/null
+++ b/packages/dart_style/test/regression/0000/0080.unit
@@ -0,0 +1,73 @@
+>>>
+void main(List argv) {
+ // This is ok (it moves the ? and : to the ends of the previous lines)
+ var cg = outputDart
+ ? new A(
+ outputDir, uri, results.libraries, results.infoMap, results.rules,
+ formatOutput)
+ : new B(
+ outputDir, uri, results.libraries, results.infoMap, results.rules);
+
+ // This gets rewritten to something much harder to read
+ // var cg = outputDart ?
+ // new ALongerClass(outputDir, uri, results.libraries, results.infoMap,
+ // results.rules, formatOutput) : new BLongerClass(
+ // outputDir, uri, results.libraries, results.infoMap, results.rules);
+ var cg = outputDart
+ ? new ALongerClass(
+ outputDir, uri, results.libraries, results.infoMap, results.rules,
+ formatOutput)
+ : new BLongerClass(
+ outputDir, uri, results.libraries, results.infoMap, results.rules);
+
+ // OK, left unchanged
+ var cg = outputDart ?
+ new A(
+ outputDir, uri, results.libraries, results.infoMap, results.rules,
+ formatOutput) :
+ new B(
+ outputDir, uri, results.libraries, results.infoMap, results.rules);
+
+ // Bad, as above
+ var cg = outputDart ?
+ new ALongerClass(
+ outputDir, uri, results.libraries, results.infoMap, results.rules,
+ formatOutput) :
+ new BLongerClass(
+ outputDir, uri, results.libraries, results.infoMap, results.rules);
+
+}
+<<<
+void main(List argv) {
+ // This is ok (it moves the ? and : to the ends of the previous lines)
+ var cg = outputDart
+ ? new A(outputDir, uri, results.libraries, results.infoMap, results.rules,
+ formatOutput)
+ : new B(
+ outputDir, uri, results.libraries, results.infoMap, results.rules);
+
+ // This gets rewritten to something much harder to read
+ // var cg = outputDart ?
+ // new ALongerClass(outputDir, uri, results.libraries, results.infoMap,
+ // results.rules, formatOutput) : new BLongerClass(
+ // outputDir, uri, results.libraries, results.infoMap, results.rules);
+ var cg = outputDart
+ ? new ALongerClass(outputDir, uri, results.libraries, results.infoMap,
+ results.rules, formatOutput)
+ : new BLongerClass(
+ outputDir, uri, results.libraries, results.infoMap, results.rules);
+
+ // OK, left unchanged
+ var cg = outputDart
+ ? new A(outputDir, uri, results.libraries, results.infoMap, results.rules,
+ formatOutput)
+ : new B(
+ outputDir, uri, results.libraries, results.infoMap, results.rules);
+
+ // Bad, as above
+ var cg = outputDart
+ ? new ALongerClass(outputDir, uri, results.libraries, results.infoMap,
+ results.rules, formatOutput)
+ : new BLongerClass(
+ outputDir, uri, results.libraries, results.infoMap, results.rules);
+}
« no previous file with comments | « packages/dart_style/test/regression/0000/0077.stmt ('k') | packages/dart_style/test/regression/0000/0081.unit » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698