packages/analyzer/lib/src/cancelable_future.dart - Issue 1400473008: Roll Observatory packages and add a roll script

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: packages/analyzer/lib/src/cancelable_future.dart

Issue 1400473008: Roll Observatory packages and add a roll script (Closed) Base URL: git@github.com:dart-lang/observatory_pub_packages.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: packages/analyzer/lib/src/cancelable_future.dart

diff --git a/analyzer/lib/src/cancelable_future.dart b/packages/analyzer/lib/src/cancelable_future.dart

similarity index 99%

rename from analyzer/lib/src/cancelable_future.dart

rename to packages/analyzer/lib/src/cancelable_future.dart

index 4ec7b269816dcb931b472ca8877bd26b470b4471..733cac55f9984e44680f5ab143087d4a75c08dce 100644

--- a/analyzer/lib/src/cancelable_future.dart

+++ b/packages/analyzer/lib/src/cancelable_future.dart

@@ -259,8 +259,8 @@ class _CancelableCompleterFuture<T> implements CancelableFuture<T> {

Future timeout(Duration timeLimit, {onTimeout()}) {

// TODO(paulberry): Implement this in such a way that a timeout cancels

// the future.

- return _completer._outerCompleter.future.timeout(timeLimit,

- onTimeout: onTimeout);

+ return _completer._outerCompleter.future

+ .timeout(timeLimit, onTimeout: onTimeout);

}

@override