Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: pkg/analysis_server/lib/src/context_manager.dart

Issue 1400473004: Options plugin initialization fix. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/context_manager_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/context_manager.dart
diff --git a/pkg/analysis_server/lib/src/context_manager.dart b/pkg/analysis_server/lib/src/context_manager.dart
index 245d61d56e76657c3cd750b85c50dc1896adba2c..5c1c0bf4fbbf46562da53a09f8bb44c88ef39a84 100644
--- a/pkg/analysis_server/lib/src/context_manager.dart
+++ b/pkg/analysis_server/lib/src/context_manager.dart
@@ -463,7 +463,7 @@ class ContextManagerImpl implements ContextManager {
}
/**
- * Process [options] for the context having info [info].
+ * Process [options] for the given context [info].
*/
void processOptionsForContext(
ContextInfo info, Map<String, YamlNode> options) {
@@ -472,9 +472,8 @@ class ContextManagerImpl implements ContextManager {
}
// Notify options processors.
- // TODO(pq): breaks AbstractContextManager tests
-// AnalysisEngine.instance.optionsPlugin.optionsProcessors.forEach(
-// (OptionsProcessor p) => p.optionsProcessed(info.context, options));
+ AnalysisEngine.instance.optionsPlugin.optionsProcessors.forEach(
+ (OptionsProcessor p) => p.optionsProcessed(info.context, options));
// Analysis options are processed 'in-line'.
// TODO(pq): consider pushing exclude handling into a plugin.
« no previous file with comments | « no previous file | pkg/analysis_server/test/context_manager_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698