src/macros.py - Issue 1400463002: [builtins] Drop useless ToBoolean JavaScript builtin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/macros.py

Issue 1400463002: [builtins] Drop useless ToBoolean JavaScript builtin. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/macros.py

diff --git a/src/macros.py b/src/macros.py

index 7f614167b4157bdf03421059656d96cce9f32fdc..7d1bcfdaf9f781ce1deab9ac06af8819b08d20dd 100644

--- a/src/macros.py

+++ b/src/macros.py

@@ -141,6 +141,7 @@ define kBoundArgumentsStartIndex = 2;

# Inline macros. Use %IS_VAR to make sure arg is evaluated only once.

macro NUMBER_IS_NAN(arg) = (!%_IsSmi(%IS_VAR(arg)) && !(arg == arg));

macro NUMBER_IS_FINITE(arg) = (%_IsSmi(%IS_VAR(arg)) || ((arg == arg) && (arg != 1/0) && (arg != -1/0)));

+macro TO_BOOLEAN(arg) = (!!arg);

Toon Verwaest 2015/10/08 08:56:56 what if arg is 1 + "test"?

Benedikt Meurer 2015/10/08 08:58:00 Done.

macro TO_INTEGER(arg) = (%_ToInteger(arg));

macro TO_INTEGER_MAP_MINUS_ZERO(arg) = (%_IsSmi(%IS_VAR(arg)) ? arg : %NumberToIntegerMapMinusZero(arg));

macro TO_INT32(arg) = (arg | 0);

« no previous file with comments | « src/debug/mirrors.js ('k') | src/prologue.js » ('j') | no next file with comments »