Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: src/debug/mirrors.js

Issue 1400463002: [builtins] Drop useless ToBoolean JavaScript builtin. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug/debug.js ('k') | src/macros.py » ('j') | src/macros.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2012 the V8 project authors. All rights reserved. 1 // Copyright 2006-2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 (function(global, utils) { 5 (function(global, utils) {
6 "use strict"; 6 "use strict";
7 7
8 // ---------------------------------------------------------------------------- 8 // ----------------------------------------------------------------------------
9 // Imports 9 // Imports
10 10
11 var FunctionSourceString; 11 var FunctionSourceString;
12 var GlobalArray = global.Array; 12 var GlobalArray = global.Array;
13 var IsNaN = global.isNaN; 13 var IsNaN = global.isNaN;
14 var JSONStringify = global.JSON.stringify; 14 var JSONStringify = global.JSON.stringify;
15 var MathMin = global.Math.min; 15 var MathMin = global.Math.min;
16 var promiseStatusSymbol = utils.ImportNow("promise_status_symbol"); 16 var promiseStatusSymbol = utils.ImportNow("promise_status_symbol");
17 var promiseValueSymbol = utils.ImportNow("promise_value_symbol"); 17 var promiseValueSymbol = utils.ImportNow("promise_value_symbol");
18 var SymbolToString; 18 var SymbolToString;
19 var ToBoolean;
20 19
21 utils.Import(function(from) { 20 utils.Import(function(from) {
22 FunctionSourceString = from.FunctionSourceString; 21 FunctionSourceString = from.FunctionSourceString;
23 SymbolToString = from.SymbolToString; 22 SymbolToString = from.SymbolToString;
24 ToBoolean = from.ToBoolean;
25 }); 23 });
26 24
27 // ---------------------------------------------------------------------------- 25 // ----------------------------------------------------------------------------
28 26
29 // Mirror hierarchy: 27 // Mirror hierarchy:
30 // - Mirror 28 // - Mirror
31 // - ValueMirror 29 // - ValueMirror
32 // - UndefinedMirror 30 // - UndefinedMirror
33 // - NullMirror 31 // - NullMirror
34 // - BooleanMirror 32 // - BooleanMirror
(...skipping 2030 matching lines...) Expand 10 before | Expand all | Expand 10 after
2065 return result; 2063 return result;
2066 }; 2064 };
2067 2065
2068 2066
2069 FrameMirror.prototype.evaluate = function(source, disable_break, 2067 FrameMirror.prototype.evaluate = function(source, disable_break,
2070 opt_context_object) { 2068 opt_context_object) {
2071 return MakeMirror(%DebugEvaluate(this.break_id_, 2069 return MakeMirror(%DebugEvaluate(this.break_id_,
2072 this.details_.frameId(), 2070 this.details_.frameId(),
2073 this.details_.inlinedFrameIndex(), 2071 this.details_.inlinedFrameIndex(),
2074 source, 2072 source,
2075 ToBoolean(disable_break), 2073 TO_BOOLEAN(disable_break),
2076 opt_context_object)); 2074 opt_context_object));
2077 }; 2075 };
2078 2076
2079 2077
2080 FrameMirror.prototype.invocationText = function() { 2078 FrameMirror.prototype.invocationText = function() {
2081 // Format frame invoaction (receiver, function and arguments). 2079 // Format frame invoaction (receiver, function and arguments).
2082 var result = ''; 2080 var result = '';
2083 var func = this.func(); 2081 var func = this.func();
2084 var receiver = this.receiver(); 2082 var receiver = this.receiver();
2085 if (this.isConstructCall()) { 2083 if (this.isConstructCall()) {
(...skipping 1026 matching lines...) Expand 10 before | Expand all | Expand 10 after
3112 // Functions needed by the debugger runtime. 3110 // Functions needed by the debugger runtime.
3113 utils.InstallFunctions(utils, DONT_ENUM, [ 3111 utils.InstallFunctions(utils, DONT_ENUM, [
3114 "ClearMirrorCache", ClearMirrorCache 3112 "ClearMirrorCache", ClearMirrorCache
3115 ]); 3113 ]);
3116 3114
3117 // Export to debug.js 3115 // Export to debug.js
3118 utils.Export(function(to) { 3116 utils.Export(function(to) {
3119 to.MirrorType = MirrorType; 3117 to.MirrorType = MirrorType;
3120 }); 3118 });
3121 }) 3119 })
OLDNEW
« no previous file with comments | « src/debug/debug.js ('k') | src/macros.py » ('j') | src/macros.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698