[builtins] Drop useless ToBoolean JavaScript builtin.

[builtins] Drop useless ToBoolean JavaScript builtin.

There's no need for a dedicated ToBoolean builtin in JavaScript, since
ToBoolean(x) can easily be expressed in JavaScript as !!x, which has the
additional advantage that the compilers are able to properly optimize
that (out of the box).

Committed: https://crrev.com/519f215137659077c7649e496ced5be516685932
Cr-Commit-Position: refs/heads/master@{#31172}

[Benedikt Meurer, 2015-10-08 07:15:25]

bmeurer@chromium.org changed reviewers:
+ verwaest@chromium.org

[Benedikt Meurer, 2015-10-08 07:15:25]

Hey Toon,

Removing awesomeness!
Please take a look.

Thanks,
Benedikt

[Toon Verwaest, 2015-10-08 08:56:56]

lgtm with one comment

https://codereview.chromium.org/1400463002/diff/1/src/macros.py
File src/macros.py (right):

https://codereview.chromium.org/1400463002/diff/1/src/macros.py#newcode144
src/macros.py:144: macro TO_BOOLEAN(arg) = (!!arg);
what if arg is 1 + "test"?

[Benedikt Meurer, 2015-10-08 08:58:00]

https://codereview.chromium.org/1400463002/diff/1/src/macros.py
File src/macros.py (right):

https://codereview.chromium.org/1400463002/diff/1/src/macros.py#newcode144
src/macros.py:144: macro TO_BOOLEAN(arg) = (!!arg);
On 2015/10/08 08:56:56, Toon Verwaest wrote:
> what if arg is 1 + "test"?

Done.

[Benedikt Meurer, 2015-10-08 08:58:10]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-10-08 08:58:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1400463002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1400463002/20001

[commit-bot: I haz the power, 2015-10-08 09:19:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-08 09:19:29]

Patchset 2 (id:??) landed as
https://crrev.com/519f215137659077c7649e496ced5be516685932
Cr-Commit-Position: refs/heads/master@{#31172}