Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1400433004: Move appengine/meta lib from infra.git (Closed)

Created:
5 years, 2 months ago by iannucci
Modified:
5 years, 2 months ago
CC:
andrew.wang, chromium-reviews, infra-reviews+luci-go_chromium.org, M-A Ruel, tandrii(chromium), todd
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -0 lines) Patch
A appengine/meta/doc.go View 1 chunk +10 lines, -0 lines 0 comments Download
A appengine/meta/eg.go View 1 chunk +37 lines, -0 lines 0 comments Download
A appengine/meta/eg_test.go View 1 chunk +54 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1399533003 Patch 1

Messages

Total messages: 6 (1 generated)
iannucci
ptal
5 years, 2 months ago (2015-10-10 01:21:25 UTC) #1
Vadim Sh.
maybe put it in luci/gae? lgtm anyway
5 years, 2 months ago (2015-10-10 01:24:27 UTC) #2
iannucci
On 2015/10/10 at 01:24:27, vadimsh wrote: > maybe put it in luci/gae? > > lgtm ...
5 years, 2 months ago (2015-10-10 01:41:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400433004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400433004/1
5 years, 2 months ago (2015-10-10 01:42:00 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-10 01:44:30 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/ef3be35160080fdcc83064f73d0c9807cbe72a45

Powered by Google App Engine
This is Rietveld 408576698