Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1400423002: Adds a new theme.css endpoint for NTP that sets the background of NTP to the current theme backgrou… (Closed)

Created:
5 years, 2 months ago by fserb
Modified:
5 years, 2 months ago
Reviewers:
*Mathieu
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds a new theme.css endpoint for NTP that sets the background of NTP to the current theme background color BUG=21798 Committed: https://crrev.com/e8eddf1482df0655c5ceaaf5a044d3669e18e34e Cr-Commit-Position: refs/heads/master@{#355133}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -14 lines) Patch
M chrome/browser/resources/local_ntp/local_ntp.css View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/local_ntp/local_ntp.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/search/local_ntp_source.cc View 1 5 chunks +34 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
fserb
5 years, 2 months ago (2015-10-14 20:26:48 UTC) #3
Mathieu
lgtm https://codereview.chromium.org/1400423002/diff/1/chrome/browser/resources/local_ntp/local_ntp.html File chrome/browser/resources/local_ntp/local_ntp.html (right): https://codereview.chromium.org/1400423002/diff/1/chrome/browser/resources/local_ntp/local_ntp.html#newcode10 chrome/browser/resources/local_ntp/local_ntp.html:10: <link rel="stylesheet" href="chrome-search://local-ntp/local-ntp.css"></link> nit: I guess we could ...
5 years, 2 months ago (2015-10-14 20:53:04 UTC) #4
fserb
https://codereview.chromium.org/1400423002/diff/1/chrome/browser/resources/local_ntp/local_ntp.html File chrome/browser/resources/local_ntp/local_ntp.html (right): https://codereview.chromium.org/1400423002/diff/1/chrome/browser/resources/local_ntp/local_ntp.html#newcode10 chrome/browser/resources/local_ntp/local_ntp.html:10: <link rel="stylesheet" href="chrome-search://local-ntp/local-ntp.css"></link> On 2015/10/14 20:53:03, Mathieu Perreault wrote: ...
5 years, 2 months ago (2015-10-20 18:48:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400423002/20001
5 years, 2 months ago (2015-10-20 18:50:08 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-20 19:35:36 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 19:36:17 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e8eddf1482df0655c5ceaaf5a044d3669e18e34e
Cr-Commit-Position: refs/heads/master@{#355133}

Powered by Google App Engine
This is Rietveld 408576698