win: Add Handles() to ProcessInfo

util/win/process_info.h

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 32 matching lines @@
     //! \brief The base address of the loaded DLL.
     WinVMAddress dll_base;
 
     //! \brief The size of the module.
     WinVMSize size;
 
     //! \brief The module's timestamp.
     time_t timestamp;
   };
 
+  struct Handle {
+    Handle();
+    ~Handle();
+
+    //! \brief A string representation of the handle's type.
+    std::wstring type_name;
+
+    //! \brief The handle's value.
+    //!
+    //! See https://msdn.microsoft.com/en-us/library/windows/desktop/aa384203 on
+    //! 32 bit being the correct size for HANDLEs for proceses, even on Windows
+    //! x64.
+    uint32_t handle;
+
+    //! \brief The attributes for the handle, e.g. `OBJ_INHERIT`,
+    //!     `OBJ_CASE_INSENSITIVE`, etc.
+    uint32_t attributes;
+
+    //! \brief The `ACCESS_MASK` for the handle in this process.
+    //!
+    //! See
+    //! http://blogs.msdn.com/b/openspecification/archive/2010/04/01/about-the-access-mask-structure.aspx
+    //! for more information.
+    uint32_t granted_access;
+
+    //! \brief The number of kernel references to the object that this handle
+    //!     refers to.
+    uint32_t pointer_count;
+
+    //! \brief The number of open handles to the object that this handle refers
+    //!     to.
+    uint32_t handle_count;
+  };
+
   ProcessInfo();
   ~ProcessInfo();
 
   //! \brief Initializes this object with information about the given
   //!     \a process.
   //!
   //! This method must be called successfully prior to calling any other
   //! method in this class. This method may only be called once.
   //!
   //! \return `true` on success, `false` on failure with a message logged.
@@ skipping 36 matching lines @@
   //! \brief Given a range to be read from the target process, returns a vector
   //!     of ranges, representing the readable portions of the original range.
   //!
   //! \param[in] range The range being identified.
   //!
   //! \return A vector of ranges corresponding to the portion of \a range that
   //!     is readable based on the memory map.
   std::vector<CheckedRange<WinVMAddress, WinVMSize>> GetReadableRanges(
       const CheckedRange<WinVMAddress, WinVMSize>& range) const;
 
+  //! \brief Retrieves information about open handles in the target process.
+  const std::vector<Handle>& Handles() const { return handles_; }

[Mark Mentovai, 2015/10/15 05:25:17]

All of the other getters aren’t inline so they can also do
INITIALIZATION_STATE_DCHECK_VALID. This should be consistent with them. Also see
the comment I left in the Initialize() implementation.

[scottmg, 2015/10/15 21:38:45]

Done.

+
  private:
   template <class Traits>
   friend bool GetProcessBasicInformation(HANDLE process,
                                          bool is_wow64,
                                          ProcessInfo* process_info,
                                          WinVMAddress* peb_address,
                                          WinVMSize* peb_size);
   template <class Traits>
   friend bool ReadProcessData(HANDLE process,
                               WinVMAddress peb_address_vmaddr,
                               ProcessInfo* process_info);
 
   friend bool ReadMemoryInfo(HANDLE process,
                              bool is_64_bit,
                              ProcessInfo* process_info);
 
+  template <class Traits>
+  std::vector<Handle> BuildHandleVector(HANDLE process) const;
+
   pid_t process_id_;
   pid_t inherited_from_process_id_;
   std::wstring command_line_;
   WinVMAddress peb_address_;
   WinVMSize peb_size_;
   std::vector<Module> modules_;
   std::vector<MEMORY_BASIC_INFORMATION64> memory_info_;
+  std::vector<Handle> handles_;
   bool is_64_bit_;
   bool is_wow64_;
   InitializationStateDcheck initialized_;
 
   DISALLOW_COPY_AND_ASSIGN(ProcessInfo);
 };
 
 //! \brief Given a memory map of a process, and a range to be read from the
 //!     target process, returns a vector of ranges, representing the readable
 //!     portions of the original range.
 //!
 //! This is a free function for testing, but prefer
 //! ProcessInfo::GetReadableRanges().
 std::vector<CheckedRange<WinVMAddress, WinVMSize>> GetReadableRangesOfMemoryMap(
     const CheckedRange<WinVMAddress, WinVMSize>& range,
     const std::vector<MEMORY_BASIC_INFORMATION64>& memory_info);
 
 }  // namespace crashpad
 
 #endif  // CRASHPAD_UTIL_WIN_PROCESS_INFO_H_