Issue 140041: Stupid....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140041: Stupid.... (Closed)

Created:
11 years, 6 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Mohamed Mansour

CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Fix download shelf display bug. BUG=14783 TEST=Download more than one thing. Shelf shouldn't get bigger everytime an item is added. Review URL: http://codereview.chromium.org/140041 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18891

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/browser/cocoa/download_shelf_controller.mm	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)

Mohamed Mansour

11 years, 6 months ago (2009-06-20 06:14:28 UTC) #1

looks good, but you should change the Subject so if someone looks at it in the
future they will know what it is about :)