Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1400393002: Use offset and count to request slices of lists, maps, and typed_data. (Closed)

Created:
5 years, 2 months ago by turnidge
Modified:
5 years, 2 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org, danrubel, devoncarew
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use offset and count to request slices of lists, maps, and typed_data. This should allow debugging clients to support pagination of these potentially large types. Closes #24536 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/cc672473b90b220c07dde30af2d667cf4520771e

Patch Set 1 #

Patch Set 2 : pre review tidy #

Total comments: 4

Patch Set 3 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+590 lines, -22 lines) Patch
M runtime/observatory/tests/service/get_object_rpc_test.dart View 5 chunks +405 lines, -1 line 0 comments Download
M runtime/vm/json_stream.h View 2 chunks +16 lines, -0 lines 0 comments Download
M runtime/vm/json_stream.cc View 1 2 2 chunks +19 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 2 5 chunks +75 lines, -16 lines 0 comments Download
M runtime/vm/service.cc View 1 2 2 chunks +18 lines, -0 lines 0 comments Download
M runtime/vm/service/service.md View 1 2 6 chunks +57 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
turnidge
5 years, 2 months ago (2015-10-14 17:46:37 UTC) #2
Cutch
LGTM with comments https://codereview.chromium.org/1400393002/diff/20001/runtime/observatory/tests/service/get_object_rpc_test.dart File runtime/observatory/tests/service/get_object_rpc_test.dart (right): https://codereview.chromium.org/1400393002/diff/20001/runtime/observatory/tests/service/get_object_rpc_test.dart#newcode10 runtime/observatory/tests/service/get_object_rpc_test.dart:10: import 'package:observatory/base64.dart'; dart:convert has a base64 ...
5 years, 2 months ago (2015-10-14 17:58:09 UTC) #3
turnidge
https://codereview.chromium.org/1400393002/diff/20001/runtime/observatory/tests/service/get_object_rpc_test.dart File runtime/observatory/tests/service/get_object_rpc_test.dart (right): https://codereview.chromium.org/1400393002/diff/20001/runtime/observatory/tests/service/get_object_rpc_test.dart#newcode10 runtime/observatory/tests/service/get_object_rpc_test.dart:10: import 'package:observatory/base64.dart'; On 2015/10/14 17:58:09, Cutch wrote: > dart:convert ...
5 years, 2 months ago (2015-10-14 18:02:42 UTC) #4
turnidge
5 years, 2 months ago (2015-10-14 18:05:26 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
cc672473b90b220c07dde30af2d667cf4520771e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698