Separate desktop and mobile media player controls image resources.

Separate desktop and mobile media player controls image resources.

blink_image_resources.grd now references separate files for mobile and desktop image resources for the post-M46 clank media player UI.  For example, "mediaplayer_play_new.png" becomes "mediaplayer_play_mobile_new.png", and "mediaplayer_play_desktop_new.png" has been added with the desktop version of the resource.

The grd file uses a variable to select between them, so that the resource names are identical internally, and so that both variants aren't packaged up with chrome.

The pre-M46 files (e.g., mediaplayer_play.png) are unaffected.

BUG=543180

[liberato (no reviews please), 2015-10-14 22:11:07]

liberato@chromium.org changed reviewers:
+ jochen@chromium.org, philipj@opera.com

[jochen (gone - plz use gerrit), 2015-10-20 09:58:59]

why are the desktop versions so small?

[philipj_slow, 2015-10-20 11:21:13]

Are the _new suffixes actually needed now?

[liberato (no reviews please), 2015-10-20 15:02:09]

On 2015/10/20 11:21:13, philipj wrote:
> Are the _new suffixes actually needed now?

small icons: just because they're currently unused.  i have larger ones, which i
will replace later.

"new": true, but it's "new" everywhere else.  in particular, the resource name
strings are easy to match up with the icons.  once the desktop version is
stable, i can get rid of all of them together along with the flags.

thanks
-fl

[philipj_slow, 2015-10-21 11:19:49]

I would like someone with more experience with the build system to take a look
at this. I have no doubt that it works, but don't know if it's frowned upon in
general to introduce new grit variables, or if there's already other ways of
achieving the same goal.

Given that the end goal is to have the very same resources on both Android and
Desktop, won't this CL have to be reverted soonish? Otherwise files will have to
be duplicated, right?

https://codereview.chromium.org/1400383002/diff/40001/third_party/WebKit/publ...
File third_party/WebKit/public/BUILD.gn (right):

https://codereview.chromium.org/1400383002/diff/40001/third_party/WebKit/publ...
third_party/WebKit/public/BUILD.gn:9: [ rebase_path("blink_headers.gypi") ],
This and a bunch of other changes in this file looks unintentional, right?

[liberato (no reviews please), 2015-10-21 14:03:02]

On 2015/10/21 11:19:49, philipj wrote:
> I would like someone with more experience with the build system to take a look
> at this. I have no doubt that it works, but don't know if it's frowned upon in
> general to introduce new grit variables, or if there's already other ways of
> achieving the same goal.
> 
> Given that the end goal is to have the very same resources on both Android and
> Desktop, won't this CL have to be reverted soonish? Otherwise files will have
to
> be duplicated, right?
> 
>
https://codereview.chromium.org/1400383002/diff/40001/third_party/WebKit/publ...
> File third_party/WebKit/public/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1400383002/diff/40001/third_party/WebKit/publ...
> third_party/WebKit/public/BUILD.gn:9: [ rebase_path("blink_headers.gypi") ],
> This and a bunch of other changes in this file looks unintentional, right?

grit: i'll find out.  the example follows things we've done elsewhere (e.g.,
https://code.google.com/p/chromium/codesearch#chromium/src/ui/keyboard/keyboa...),
so i'm hoping it's okay here too.

revert: unfortunately, maybe not.  after trying the mobile ui on desktop,
consensus was that it was too white spacey.  in the ensuing adjustments, some of
the resources changed.  i'm not sure that i will be able to unify them.  this
seemed like a really easy way to let me make progress without blocking on that,
and without breaking anything.

before i do anything else with this, i'll see if i can factor all the resource
differences into css changes instead.

[philipj_slow, 2015-10-22 08:03:39]

On 2015/10/21 14:03:02, liberato wrote:
> On 2015/10/21 11:19:49, philipj wrote:
> > I would like someone with more experience with the build system to take a
look
> > at this. I have no doubt that it works, but don't know if it's frowned upon
in
> > general to introduce new grit variables, or if there's already other ways of
> > achieving the same goal.
> > 
> > Given that the end goal is to have the very same resources on both Android
and
> > Desktop, won't this CL have to be reverted soonish? Otherwise files will
have
> to
> > be duplicated, right?
> > 
> >
>
https://codereview.chromium.org/1400383002/diff/40001/third_party/WebKit/publ...
> > File third_party/WebKit/public/BUILD.gn (right):
> > 
> >
>
https://codereview.chromium.org/1400383002/diff/40001/third_party/WebKit/publ...
> > third_party/WebKit/public/BUILD.gn:9: [ rebase_path("blink_headers.gypi") ],
> > This and a bunch of other changes in this file looks unintentional, right?
> 
> grit: i'll find out.  the example follows things we've done elsewhere (e.g.,
>
https://code.google.com/p/chromium/codesearch#chromium/src/ui/keyboard/keyboa...),
> so i'm hoping it's okay here too.
> 
> revert: unfortunately, maybe not.  after trying the mobile ui on desktop,
> consensus was that it was too white spacey.  in the ensuing adjustments, some
of
> the resources changed.  i'm not sure that i will be able to unify them.  this
> seemed like a really easy way to let me make progress without blocking on
that,
> and without breaking anything.
> 
> before i do anything else with this, i'll see if i can factor all the resource
> differences into css changes instead.

Oh, well I do agree that there's too much padding on Desktop. If it's just a
matter of having less padding around the graphics it should indeed be possible
to do it with just CSS.