src/interpreter/bytecode-generator.cc - Issue 1400353002: [Interpreter]: Use vector store for array literal computed stores.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecode-generator.cc

Issue 1400353002: [Interpreter]: Use vector store for array literal computed stores. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/interpreter/bytecode-generator.cc

diff --git a/src/interpreter/bytecode-generator.cc b/src/interpreter/bytecode-generator.cc

index 5f321201df4e0f9c76b6b853d446c96586e7d2a8..db351885a2a5b8d30d3f612df23e39f6b3d0d75e 100644

--- a/src/interpreter/bytecode-generator.cc

+++ b/src/interpreter/bytecode-generator.cc

@@ -712,7 +712,9 @@ void BytecodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) {

->LoadLiteral(Smi::FromInt(array_index))

.StoreAccumulatorInRegister(index);

Visit(subexpr);

- builder()->GenericStoreKeyedProperty(literal, index);

+ FeedbackVectorSlot slot = expr->LiteralFeedbackSlot();

+ builder()->StoreKeyedProperty(literal, index, feedback_index(slot),

+ language_mode());

}

if (!literal_in_accumulator) {

« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | src/interpreter/bytecodes.h » ('j') | no next file with comments »