src/codec/SkBmpStandardCodec.cpp - Issue 1400343005: Reenable warnings in src/codec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkBmpStandardCodec.cpp

Issue 1400343005: Reenable warnings in src/codec (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Response to comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkBmpStandardCodec.cpp

diff --git a/src/codec/SkBmpStandardCodec.cpp b/src/codec/SkBmpStandardCodec.cpp

index 955760936000ffc0bd82102d6753b26fbc0729c7..fd4d6d18bc2d3df2ea6366554dc3bf56ec72700e 100644

--- a/src/codec/SkBmpStandardCodec.cpp

+++ b/src/codec/SkBmpStandardCodec.cpp

@@ -55,7 +55,7 @@ SkCodec::Result SkBmpStandardCodec::onGetPixels(const SkImageInfo& dstInfo,

if (kSuccess != result) {

return result;

}

- uint32_t rows = this->decodeRows(dstInfo, dst, dstRowBytes, opts);

+ int rows = this->decodeRows(dstInfo, dst, dstRowBytes, opts);

if (rows != dstInfo.height()) {

*rowsDecoded = rows;

return kIncompleteInput;

« no previous file with comments | « src/codec/SkBmpRLECodec.cpp ('k') | src/codec/SkCodec_libgif.cpp » ('j') | no next file with comments »