src/codec/SkBmpRLECodec.cpp - Issue 1400343005: Reenable warnings in src/codec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkBmpRLECodec.cpp

Issue 1400343005: Reenable warnings in src/codec (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Response to comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkBmpRLECodec.cpp

diff --git a/src/codec/SkBmpRLECodec.cpp b/src/codec/SkBmpRLECodec.cpp

index e215095266ab26cb53b3f27b79f95293c6d535de..67e262a704cae19489f0424baff6fe73329cc3ce 100644

--- a/src/codec/SkBmpRLECodec.cpp

+++ b/src/codec/SkBmpRLECodec.cpp

@@ -55,7 +55,7 @@ SkCodec::Result SkBmpRLECodec::onGetPixels(const SkImageInfo& dstInfo,

}

// Perform the decode

- uint32_t rows = this->decodeRows(dstInfo, dst, dstRowBytes, opts);

+ int rows = this->decodeRows(dstInfo, dst, dstRowBytes, opts);

if (rows != dstInfo.height()) {

// We set rowsDecoded equal to the height because the background has already

// been filled. RLE encodings sometimes skip pixels, so we always start by

« no previous file with comments | « src/codec/SkBmpMaskCodec.cpp ('k') | src/codec/SkBmpStandardCodec.cpp » ('j') | no next file with comments »