Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: src/gpu/GrClipMaskManager.h

Issue 1400343004: Fix clipping when all analytic FP creations can be skipped (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: fix speeling Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/gpu/GrClipMaskManager.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrClipMaskManager.h
diff --git a/src/gpu/GrClipMaskManager.h b/src/gpu/GrClipMaskManager.h
index 005830c1a78861ff626cbc35186c5819b4835c12..90352f4621060eb42290bb9b50f4ff6ef2b41307 100644
--- a/src/gpu/GrClipMaskManager.h
+++ b/src/gpu/GrClipMaskManager.h
@@ -87,10 +87,13 @@ private:
};
// Attempts to install a series of coverage effects to implement the clip. Return indicates
- // whether the element list was successfully converted to effects.
- const GrFragmentProcessor* getAnalyticClipProcessor(const GrReducedClip::ElementList&,
- const SkVector& clipOffset,
- const SkRect* devBounds);
+ // whether the element list was successfully converted to processors. *fp may be nullptr even
+ // when the function succeeds because all the elements were ignored. TODO: Make clip reduction
+ // bounds-aware and stop checking bounds in this function.
+ bool getAnalyticClipProcessor(const GrReducedClip::ElementList&,
+ SkVector& clipOffset,
+ const SkRect* devBounds,
+ const GrFragmentProcessor** fp);
// Draws the clip into the stencil buffer
bool createStencilClipMask(GrRenderTarget*,
« no previous file with comments | « no previous file | src/gpu/GrClipMaskManager.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698