Issue 140033: Changing overstrict CHECKs to just setting the object into an invalid state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140033: Changing overstrict CHECKs to just setting the object into an invalid state. (Closed)

Created:
11 years, 6 months ago by awong

Modified:
9 years, 7 months ago

Reviewers:
fbarchard

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Changing overstrict CHECKs to just setting the object into an invalid state. BUG: 13287

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -5 lines)			Patch
	M	media/audio/linux/alsa_output.cc	View		1 chunk	+17 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

fbarchard

11 years, 6 months ago (2009-06-20 00:51:56 UTC) #2

LGTM
Step in the right direction albert.
we need multichannel fairly soon, and these other PCM formats could potentially
come up, and its best we report them, rather than DCHECK

Expand Messages | Collapse Messages