scripts/slave/recipe_modules/webrtc/chromium_config.py - Issue 1400283004: WebRTC: Remove build_with_chromium=false flag for GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/webrtc/chromium_config.py

Issue 1400283004: WebRTC: Remove build_with_chromium=false flag for GN (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/webrtc/chromium_config.py

diff --git a/scripts/slave/recipe_modules/webrtc/chromium_config.py b/scripts/slave/recipe_modules/webrtc/chromium_config.py

index c54d7aa039822dfaf298dd4038d8888b1414c0ff..391ddd58f6307ab91c979948f88ec9e9cc7ebff8 100644

--- a/scripts/slave/recipe_modules/webrtc/chromium_config.py

+++ b/scripts/slave/recipe_modules/webrtc/chromium_config.py

@@ -49,7 +49,6 @@ def webrtc_ios(c):

@CONFIG_CTX(includes=['gn'])

def webrtc_gn(c):

c.compile_py.default_targets = ['all']

kjellander_chromium 2015/10/14 10:58:46 The config is still needed because without it, GN

- c.project_generator.args = ['build_with_chromium=false']

def _compiler_defaults(c):

c.compile_py.default_targets = ['All']

« no previous file with comments | « no previous file | scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_gn.json » ('j') | no next file with comments »