Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1400283004: WebRTC: Remove build_with_chromium=false flag for GN (Closed)

Created:
5 years, 2 months ago by kjellander_chromium
Modified:
5 years, 1 month ago
Reviewers:
Michael Achenbach
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
build
Visibility:
Public.

Description

WebRTC: Remove build_with_chromium=false flag for GN After https://codereview.webrtc.org/1403453003/ we no longer need to pass build_with_chromium=false for standalone WebRTC builds. It's possible all bots will need a clobber build after landing this, since they'll have args.gn files in the out/ tree containing the variable previously passed via --args. BUG=webrtc:5070 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297312

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M scripts/slave/recipe_modules/webrtc/chromium_config.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_gn.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_gn__dbg_.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug__gn_.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__gn_.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug__gn_.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release__gn_.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug__gn_.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release__gn_.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_gn_dbg.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_gn_rel.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_gn_dbg.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_gn_rel.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_x64_gn_dbg.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_x64_gn_rel.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_gn_dbg.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_gn_rel.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
kjellander_chromium
https://codereview.chromium.org/1400283004/diff/1/scripts/slave/recipe_modules/webrtc/chromium_config.py File scripts/slave/recipe_modules/webrtc/chromium_config.py (right): https://codereview.chromium.org/1400283004/diff/1/scripts/slave/recipe_modules/webrtc/chromium_config.py#newcode51 scripts/slave/recipe_modules/webrtc/chromium_config.py:51: c.compile_py.default_targets = ['all'] The config is still needed because ...
5 years, 2 months ago (2015-10-14 10:58:47 UTC) #2
Michael Achenbach
lgtm - do you support landmines for the clobber? Otherwise it'll be tedious clobbering all ...
5 years, 2 months ago (2015-10-14 11:15:12 UTC) #3
kjellander_chromium
On 2015/10/14 11:15:12, Michael Achenbach wrote: > lgtm - do you support landmines for the ...
5 years, 1 month ago (2015-10-27 10:30:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400283004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400283004/20001
5 years, 1 month ago (2015-10-27 10:31:25 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 10:33:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297312

Powered by Google App Engine
This is Rietveld 408576698