https://codereview.chromium.org/1400283004/diff/1/scripts/slave/recipe_modules/webrtc/chromium_config.py File scripts/slave/recipe_modules/webrtc/chromium_config.py (right): https://codereview.chromium.org/1400283004/diff/1/scripts/slave/recipe_modules/webrtc/chromium_config.py#newcode51 scripts/slave/recipe_modules/webrtc/chromium_config.py:51: c.compile_py.default_targets = ['all'] The config is still needed because ...
5 years, 2 months ago
(2015-10-14 10:58:47 UTC)
#2
https://codereview.chromium.org/1400283004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/webrtc/chromium_config.py (right):
https://codereview.chromium.org/1400283004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/webrtc/chromium_config.py:51:
c.compile_py.default_targets = ['all']
The config is still needed because without it, GN on Windows will get the 'All'
target, which fails to build (only 'all' exists for GN).
I considered cleaning up our webrtc_standalone config, but I don't think it's
useful since we'll be specifying individual targets when we start using analyze
anyway, so I'm punting that work.
Michael Achenbach
lgtm - do you support landmines for the clobber? Otherwise it'll be tedious clobbering all ...
5 years, 2 months ago
(2015-10-14 11:15:12 UTC)
#3
lgtm - do you support landmines for the clobber? Otherwise it'll be tedious
clobbering all the shared directories on slaves from slave pools.
kjellander_chromium
On 2015/10/14 11:15:12, Michael Achenbach wrote: > lgtm - do you support landmines for the ...
On 2015/10/14 11:15:12, Michael Achenbach wrote:
> lgtm - do you support landmines for the clobber? Otherwise it'll be tedious
> clobbering all the shared directories on slaves from slave pools.
Delayed update: landmines support was added in
https://code.google.com/p/webrtc/issues/detail?id=5070 so I will land this now.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400283004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400283004/20001
Issue 1400283004: WebRTC: Remove build_with_chromium=false flag for GN
(Closed)
Created 5 years, 2 months ago by kjellander_chromium
Modified 5 years, 1 month ago
Reviewers: Michael Achenbach
Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Comments: 1