Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 140026: Add the ability to resize the window when over the custom frame. (Closed)

Created:
11 years, 6 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, pfeldman
CC:
chromium-reviews_googlegroups.com, Dean McNamee
Visibility:
Public.

Description

Add the ability to resize the window when over the custom frame. I also switched from 3px borders to 4px borders because that's what they are on windows. On linux, the borders look bigger because our webcontent area doesn't drop a shadow. For this to work for resizing on top, I had to remove the event box from the browser titlebar and move the mouse event handling to the window. BUG=14645

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix tab offset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -68 lines) Patch
M chrome/browser/gtk/browser_titlebar.h View 3 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/gtk/browser_titlebar.cc View 6 chunks +16 lines, -36 lines 0 comments Download
M chrome/browser/gtk/browser_toolbar_gtk.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.h View 4 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.cc View 9 chunks +200 lines, -19 lines 0 comments Download
M chrome/browser/gtk/tabs/tab_renderer_gtk.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tony
11 years, 6 months ago (2009-06-19 23:22:54 UTC) #1
Evan Martin
LGTM http://codereview.chromium.org/140026/diff/1/3 File chrome/browser/gtk/browser_titlebar.h (right): http://codereview.chromium.org/140026/diff/1/3#newcode40 Line 40: void ShowContextMenu(); Why move this? http://codereview.chromium.org/140026/diff/1/4 File ...
11 years, 6 months ago (2009-06-19 23:27:46 UTC) #2
tony
I also fixed the tab offset bug. Now the tabs are located in the right ...
11 years, 6 months ago (2009-06-20 22:54:17 UTC) #3
pfeldman
It looks like as of this change click events in DevTools window are considered drag ...
11 years, 5 months ago (2009-06-29 12:08:38 UTC) #4
tony
11 years, 5 months ago (2009-06-29 17:04:57 UTC) #5
I filed bug 15576 and will fix it today.

On 2009/06/29 12:08:38, pfeldman wrote:
> It looks like as of this change click events in DevTools window are considered
> drag events. Could it be the case?
> 
> Thanks
> Pavel

Powered by Google App Engine
This is Rietveld 408576698