Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 1400253002: Put experimental extras through the same filters as non-experimental (Closed)

Created:
5 years, 2 months ago by domenic
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Put experimental extras through the same filters as non-experimental When introducing experimental extras I forgot to update this check. That resulted in experimental extras running through the steps normally reserved for non-extra natives: macro and constant expansion, validation, and minification. This causes problems since per the linked bug minification is buggy. R=yangguo@chromium.org, jochen@chromium.org BUG=v8:4064 LOG=N Committed: https://crrev.com/0db3710421f0ed187ab97ecb29f1121a4c9278c9 Cr-Commit-Position: refs/heads/master@{#31270}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/js2c.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
domenic
One-line change This is how I feel about this patch: http://i.imgur.com/MyN2XKd.gif
5 years, 2 months ago (2015-10-13 20:56:57 UTC) #1
Yang
On 2015/10/13 20:56:57, domenic wrote: > One-line change > > This is how I feel ...
5 years, 2 months ago (2015-10-14 11:10:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400253002/1
5 years, 2 months ago (2015-10-14 15:51:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 17:38:35 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 17:38:53 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0db3710421f0ed187ab97ecb29f1121a4c9278c9
Cr-Commit-Position: refs/heads/master@{#31270}

Powered by Google App Engine
This is Rietveld 408576698