Update telemetry tests that rely on window.innerWidth/Height.

Update telemetry tests that rely on window.innerWidth/Height.

window.scroll properties have been relative to the visual viewport. This breaks
some pages under pinch-zoom (see crbug.com/489206). This CL fixes the telemetry
tests that would fail if window.scroll properties are changed to be relative
to the layout viewport. This CL adds an api method to get the visual viewport
size instead of getting it from window.innerWidth and window.innerHeight.

See crbug.com/433794 for some history.

BUG=489206
Committed: https://crrev.com/e81760ea8fd85cf9ae2900e3978dd600bbb3c8e0
Cr-Commit-Position: refs/heads/master@{#354071}

[ymalik, 2015-10-13 17:26:38]

ymalik@chromium.org changed reviewers:
+ bokan@chromium.org

[ymalik, 2015-10-13 17:28:15]

On 2015/10/13 17:26:56, ymalik1 wrote:

@bokan

Need your stamp before I add specific owners :)

[bokan, 2015-10-13 17:30:29]

lgtm

[ymalik (do not use), 2015-10-13 18:21:37]

ymalik@google.com changed reviewers:
+ avi@chromium.org, rbyers@chromium.org

[ymalik (do not use), 2015-10-13 18:23:56]

ymalik@google.com changed reviewers:
+ ymalik@google.com

[ymalik (do not use), 2015-10-13 18:23:56]

+avi@ for content/renderer/gpu
+rbyers@ for WebKit/public/web

[ymalik (do not use), 2015-10-13 18:25:54]

ymalik@google.com changed reviewers:
+ skyostil@chromium.org

[ymalik (do not use), 2015-10-13 18:25:54]

+skyostil@ for tools/telemetry

[Avi (use Gerrit), 2015-10-13 20:25:19]

stampity stamp lgtm

[Sami, 2015-10-14 10:44:38]

https://codereview.chromium.org/1400213002/diff/1/tools/telemetry/telemetry/i...
File tools/telemetry/telemetry/internal/actions/gesture_common.js (right):

https://codereview.chromium.org/1400213002/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/actions/gesture_common.js:43:
chrome.gpuBenchmarking.visualViewportHeight();
Some telemetry tests run against older reference builds which won't have these
new properties. Could you write this in a way that works in both cases (with a
TODO to remove the fallback path after once the properties roll into stable)?

/me wonders if the visual viewport dimensions should be exposed to the web
platform too...

[ymalik, 2015-10-14 15:56:10]

https://codereview.chromium.org/1400213002/diff/1/tools/telemetry/telemetry/i...
File tools/telemetry/telemetry/internal/actions/gesture_common.js (right):

https://codereview.chromium.org/1400213002/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/actions/gesture_common.js:43:
chrome.gpuBenchmarking.visualViewportHeight();
On 2015/10/14 10:44:38, Sami wrote:
> Some telemetry tests run against older reference builds which won't have these
> new properties. Could you write this in a way that works in both cases (with a
> TODO to remove the fallback path after once the properties roll into stable)?
> 
> /me wonders if the visual viewport dimensions should be exposed to the web
> platform too...

Done. 

We do have plans in the future (perhaps next quarter) to expose the visual
viewport dimensions to the web platform.

[Sami, 2015-10-14 16:04:59]

Thanks, lgtm.

[ymalik, 2015-10-14 16:49:52]

The CQ bit was checked by ymalik@chromium.org

[ymalik, 2015-10-14 16:49:52]

The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org,
avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1400213002/#ps20001
(title: "Worked on review comments")

[commit-bot: I haz the power, 2015-10-14 16:50:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1400213002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1400213002/20001

[commit-bot: I haz the power, 2015-10-14 17:00:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-14 17:00:49]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ymalik (do not use), 2015-10-14 17:14:27]

@rbyers

Just need a stamp from you :)

[Rick Byers, 2015-10-14 17:42:22]

WebKit/public LGTM

[ymalik, 2015-10-14 18:00:33]

The CQ bit was checked by ymalik@chromium.org

[commit-bot: I haz the power, 2015-10-14 18:00:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1400213002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1400213002/20001

[commit-bot: I haz the power, 2015-10-14 18:24:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-14 18:25:27]

Patchset 2 (id:??) landed as
https://crrev.com/e81760ea8fd85cf9ae2900e3978dd600bbb3c8e0
Cr-Commit-Position: refs/heads/master@{#354071}