Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 14002007: allow tests to optionally use multiple threads (Closed)

Created:
7 years, 8 months ago by caryclark
Modified:
7 years, 8 months ago
Reviewers:
borenet, mtklein, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

allow tests to optionally use multiple threads modify threaded path ops tests to check Background: this CL came out of a conversation with Eric where I learned that 10s of machines host 100s of bots. Since the bot hosting tests may be shared with many other tasks, it seems unwise for path ops to launch multiple test threads. The change here is to make launching multiple threads "opt-in" and by default, bots can run path ops in a single thread. Committed: https://code.google.com/p/skia/source/detail?r=8750

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
M tests/PathOpsExtendedTest.h View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsExtendedTest.cpp View 2 chunks +2 lines, -8 lines 0 comments Download
M tests/PathOpsOpCubicThreadedTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsOpRectThreadedTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsQuadLineIntersectionThreadedTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsSimplifyDegenerateThreadedTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsSimplifyQuadThreadedTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsSimplifyQuadralateralsThreadedTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsSimplifyRectThreadedTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsSimplifyTrianglesThreadedTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/Test.h View 1 chunk +1 line, -1 line 0 comments Download
M tests/skia_test.cpp View 5 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
caryclark
7 years, 8 months ago (2013-04-18 18:17:50 UTC) #1
reed1
7 years, 8 months ago (2013-04-18 18:31:19 UTC) #2
caryclark
7 years, 8 months ago (2013-04-18 18:34:57 UTC) #3
mtklein
I've got a change out to parallelize test execution at the granularity of a test ...
7 years, 8 months ago (2013-04-18 18:39:48 UTC) #4
caryclark
7 years, 8 months ago (2013-04-18 18:47:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r8750 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698