Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1400193003: Don't assume at least one closure function is encountered before tree-shaking. Allow… (Closed)

Created:
5 years, 2 months ago by rmacnak
Modified:
5 years, 2 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't assume at least one closure function is encountered before tree-shaking. Allow for uncompiled closure functions and drop them. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/1a5a8fb58a6af72fbad374d0c1c29786fafa4e10

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -24 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 2 1 chunk +9 lines, -8 lines 0 comments Download
M runtime/vm/object.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 2 chunks +28 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 2 months ago (2015-10-13 20:59:28 UTC) #2
srdjan
lgtm https://codereview.chromium.org/1400193003/diff/20001/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://codereview.chromium.org/1400193003/diff/20001/runtime/vm/flow_graph_builder.cc#newcode2534 runtime/vm/flow_graph_builder.cc:2534: if (isolate->collected_closures() != GrowableObjectArray::null()) { Please add a ...
5 years, 2 months ago (2015-10-13 21:30:12 UTC) #3
rmacnak
https://codereview.chromium.org/1400193003/diff/20001/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://codereview.chromium.org/1400193003/diff/20001/runtime/vm/flow_graph_builder.cc#newcode2534 runtime/vm/flow_graph_builder.cc:2534: if (isolate->collected_closures() != GrowableObjectArray::null()) { On 2015/10/13 21:30:12, srdjan ...
5 years, 2 months ago (2015-10-13 21:55:02 UTC) #4
rmacnak
5 years, 2 months ago (2015-10-13 21:56:39 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
1a5a8fb58a6af72fbad374d0c1c29786fafa4e10 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698