Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1400143002: Enable complex text for fast/text tests (Closed)

Created:
5 years, 2 months ago by eae
Modified:
5 years, 2 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable complex text for fast/text tests R=drott@chromium.org BUG=404597 Committed: https://crrev.com/29595fd381b8e4872d6e926fb138680e7e67c8d3 Cr-Commit-Position: refs/heads/master@{#353729}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Merge TestExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -14 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 7 chunks +206 lines, -13 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
eae
First of many...
5 years, 2 months ago (2015-10-13 09:28:48 UTC) #2
leviw_travelin_and_unemployed
lgtm https://codereview.chromium.org/1400143002/diff/1/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/1400143002/diff/1/third_party/WebKit/LayoutTests/TestExpectations#newcode47 third_party/WebKit/LayoutTests/TestExpectations:47: Bug(eae) [ XP Win7 Linux Android Mac ] ...
5 years, 2 months ago (2015-10-13 09:31:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400143002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400143002/80001
5 years, 2 months ago (2015-10-13 12:10:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400143002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400143002/80001
5 years, 2 months ago (2015-10-13 13:03:20 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 2 months ago (2015-10-13 13:10:50 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 13:11:34 UTC) #12
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/29595fd381b8e4872d6e926fb138680e7e67c8d3
Cr-Commit-Position: refs/heads/master@{#353729}

Powered by Google App Engine
This is Rietveld 408576698