Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: third_party/mojo/src/mojo/public/tools/bindings/mojom.gni

Issue 1400123002: Make mojom targets depend on chromium mojo environment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: don't not invert the boolean Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/mojo/src/mojo/public/interfaces/bindings/tests/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/mojo/src/mojo/public/tools/bindings/mojom.gni
diff --git a/third_party/mojo/src/mojo/public/tools/bindings/mojom.gni b/third_party/mojo/src/mojo/public/tools/bindings/mojom.gni
index b72e96a8a2837d80c6a7d4dfaf303077229392d9..1a9873a40aaea9e8575539cd916ea95ed3416ae5 100644
--- a/third_party/mojo/src/mojo/public/tools/bindings/mojom.gni
+++ b/third_party/mojo/src/mojo/public/tools/bindings/mojom.gni
@@ -38,6 +38,11 @@ import("../../mojo_sdk.gni")
# import_dirs (optional)
# List of import directories that will get added when processing sources.
#
+# with_environment (optional)
+# Set to |false| to omit an implicit bindings dependency on the Chromium
+# Mojo environment implementation. Defaults to |true| and in general
+# should only be overridden by mojom targets within the Mojo EDK.
+#
# testonly (optional)
#
# visibility (optional)
@@ -151,8 +156,8 @@ template("mojom") {
script = generator_script
inputs = generator_sources
sources = invoker.sources
- outputs = generator_cpp_outputs + generator_java_outputs +
- generator_js_outputs
+ outputs =
+ generator_cpp_outputs + generator_java_outputs + generator_js_outputs
args = [
"{{source}}",
"--use_bundled_pylibs",
@@ -266,6 +271,9 @@ template("mojom") {
full_name = get_label_info(d, "label_no_toolchain")
deps += [ "${full_name}_${cpp_sources_suffix}" ]
}
+ if (!defined(invoker.with_environment) || invoker.with_environment) {
+ deps += [ "//mojo/environment:chromium" ]
+ }
}
}
« no previous file with comments | « third_party/mojo/src/mojo/public/interfaces/bindings/tests/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698