Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 1400043002: Promote documents in md-pages branch. (Closed)

Created:
5 years, 2 months ago by yukawa
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
gyp-developer_googlegroups.com, scottmg, Mark Mentovai
Base URL:
https://chromium.googlesource.com/external/gyp@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Promote documents in md-pages branch. Seems that now both master branch and md-pages branch have docs/ directory, but only the latter looks to be maintained. https://chromium.googlesource.com/external/gyp/+/master/docs/ https://chromium.googlesource.com/external/gyp/+/md-pages/docs/ This might be a bit confusing for users and contributors, since they could be easily navigated to those documents in master branch in the following steps. 1. Search 'GYP' then be navigated to https://code.google.com/p/gyp 2. Find 'Source' tab and click it to be navigated to https://code.google.com/p/gyp/wiki/Source?tm=4 3. Find a new repository URL. https://chromium.googlesource.com/external/gyp 4. Find a 'Hacking' guide w/o realizing that the document is a bit out of date. https://chromium.googlesource.com/external/gyp/+/HEAD/docs/Hacking.md With this CL, hopefully users and contributors can find the latest documents. BUG= R=dpranke@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/8f3918d7408f5434f16964d68a8ce58570215f3c

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3208 lines) Patch
M README.md View 1 chunk +2 lines, -10 lines 0 comments Download
D docs/Buildbot.md View 1 chunk +0 lines, -9 lines 0 comments Download
D docs/GypVsCMake.md View 1 chunk +0 lines, -118 lines 0 comments Download
D docs/Hacking.md View 1 chunk +0 lines, -77 lines 0 comments Download
D docs/InputFormatReference.md View 1 chunk +0 lines, -1082 lines 0 comments Download
D docs/LanguageSpecification.md View 1 chunk +0 lines, -475 lines 0 comments Download
D docs/Source.md View 1 chunk +0 lines, -3 lines 0 comments Download
D docs/Testing.md View 1 chunk +0 lines, -459 lines 0 comments Download
D docs/UserDocumentation.md View 1 chunk +0 lines, -975 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
yukawa
Hi Dirk. Per your post at https://groups.google.com/d/msg/gyp-developer/9Ph3k7n3juQ/8ge5vvSdKQAJ, I think it makes sense to remove docs/ ...
5 years, 2 months ago (2015-10-12 20:03:42 UTC) #2
Dirk Pranke
Since most contributors probably only have the master branch checked out, it's probably better that ...
5 years, 2 months ago (2015-10-12 21:02:28 UTC) #5
Nico
On 2015/10/12 21:02:28, Dirk Pranke wrote: > Since most contributors probably only have the master ...
5 years, 2 months ago (2015-10-12 21:18:59 UTC) #6
yukawa
On 2015/10/12 21:18:59, Nico wrote: > On 2015/10/12 21:02:28, Dirk Pranke wrote: > > Since ...
5 years, 2 months ago (2015-10-12 21:47:50 UTC) #8
yukawa
On 2015/10/12 21:47:50, yukawa wrote: > On 2015/10/12 21:18:59, Nico wrote: > > On 2015/10/12 ...
5 years, 2 months ago (2015-10-12 21:57:47 UTC) #9
Dirk Pranke
I guess I'm fine w/ deleting the files on the master branch. Keeping the docs ...
5 years, 2 months ago (2015-10-12 22:15:41 UTC) #10
yukawa
On 2015/10/12 22:15:41, Dirk Pranke wrote: > I guess I'm fine w/ deleting the files ...
5 years, 2 months ago (2015-10-12 22:25:12 UTC) #12
Dirk Pranke
lgtm
5 years, 2 months ago (2015-10-12 22:26:15 UTC) #13
yukawa
5 years, 2 months ago (2015-10-12 22:27:21 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:40001) manually as
8f3918d7408f5434f16964d68a8ce58570215f3c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698