Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1400003005: Refactor mojo_benchmark to get rid of warm/cold start special cases. (Closed)

Created:
5 years, 2 months ago by ppi
Modified:
5 years, 2 months ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Refactor mojo_benchmark to get rid of warm/cold start special cases. This patch extracts a pre-processing step in mojo_benchmark that rewrites the given list of benchmarks to run, yielding two benchmarks corresponding to the warm start case and to the cold start case for each benchmark defined in the original list. This simplifies the logic afterwards which does not need to reason about cold start vs warm start cases. This will also allow us to easily add other variants in the future. R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/17b94ae165808758460062091779fab5ba14c20d

Patch Set 1 : #

Total comments: 6

Patch Set 2 : Address Trung's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -28 lines) Patch
M mojo/devtools/common/mojo_benchmark View 1 4 chunks +44 lines, -28 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ppi
Hi Trung, can you tal? People familiar with this code are probably sleeping now.
5 years, 2 months ago (2015-10-14 20:55:39 UTC) #3
viettrungluu
lgtm w/some suggestions/comments https://codereview.chromium.org/1400003005/diff/20001/mojo/devtools/common/mojo_benchmark File mojo/devtools/common/mojo_benchmark (right): https://codereview.chromium.org/1400003005/diff/20001/mojo/devtools/common/mojo_benchmark#newcode69 mojo/devtools/common/mojo_benchmark:69: result = list() Probably "= []" ...
5 years, 2 months ago (2015-10-14 21:24:17 UTC) #4
ppi
Thanks! https://codereview.chromium.org/1400003005/diff/20001/mojo/devtools/common/mojo_benchmark File mojo/devtools/common/mojo_benchmark (right): https://codereview.chromium.org/1400003005/diff/20001/mojo/devtools/common/mojo_benchmark#newcode69 mojo/devtools/common/mojo_benchmark:69: result = list() On 2015/10/14 21:24:16, viettrungluu wrote: ...
5 years, 2 months ago (2015-10-14 21:47:27 UTC) #5
ppi
5 years, 2 months ago (2015-10-14 21:48:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
17b94ae165808758460062091779fab5ba14c20d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698