Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Side by Side Diff: content/renderer/render_view_impl.h

Issue 1400003003: Move has_focus_ tracking from RenderWidget to RenderView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Leave OnSetFocus plumbing alone Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
225 225
226 bool is_loading() const { return frames_in_progress_ != 0; } 226 bool is_loading() const { return frames_in_progress_ != 0; }
227 227
228 void FrameDidStartLoading(blink::WebFrame* frame); 228 void FrameDidStartLoading(blink::WebFrame* frame);
229 void FrameDidStopLoading(blink::WebFrame* frame); 229 void FrameDidStopLoading(blink::WebFrame* frame);
230 230
231 // Sets the zoom level and notifies observers. Doesn't call zoomLevelChanged, 231 // Sets the zoom level and notifies observers. Doesn't call zoomLevelChanged,
232 // as that is only for changes that aren't initiated by the client. 232 // as that is only for changes that aren't initiated by the client.
233 void SetZoomLevel(double zoom_level); 233 void SetZoomLevel(double zoom_level);
234 234
235 bool has_focus() const { return has_focus_; }
Charlie Reis 2015/10/14 19:32:52 Let's document what this means. It's page-level f
alexmos 2015/10/14 20:12:33 Done.
236
235 // Plugin-related functions -------------------------------------------------- 237 // Plugin-related functions --------------------------------------------------
236 238
237 #if defined(ENABLE_PLUGINS) 239 #if defined(ENABLE_PLUGINS)
238 // Get/set the plugin which will be used as to handle document find requests. 240 // Get/set the plugin which will be used as to handle document find requests.
239 void set_plugin_find_handler(PepperPluginInstanceImpl* plugin) { 241 void set_plugin_find_handler(PepperPluginInstanceImpl* plugin) {
240 plugin_find_handler_ = plugin; 242 plugin_find_handler_ = plugin;
241 } 243 }
242 PepperPluginInstanceImpl* plugin_find_handler() { 244 PepperPluginInstanceImpl* plugin_find_handler() {
243 return plugin_find_handler_; 245 return plugin_find_handler_;
244 } 246 }
(...skipping 621 matching lines...) Expand 10 before | Expand all | Expand 10 after
866 868
867 // Indicates whether this view overrides url-based zoom settings. 869 // Indicates whether this view overrides url-based zoom settings.
868 bool uses_temporary_zoom_level_; 870 bool uses_temporary_zoom_level_;
869 871
870 #if defined(OS_ANDROID) 872 #if defined(OS_ANDROID)
871 // Cache the old top controls state constraints. Used when updating 873 // Cache the old top controls state constraints. Used when updating
872 // current value only without altering the constraints. 874 // current value only without altering the constraints.
873 TopControlsState top_controls_constraints_; 875 TopControlsState top_controls_constraints_;
874 #endif 876 #endif
875 877
878 // Indicates whether we have been focused/unfocused by the browser.
Charlie Reis 2015/10/14 19:32:52 s/we have/this page has/
alexmos 2015/10/14 20:12:33 Done.
879 bool has_focus_;
880
876 // View ---------------------------------------------------------------------- 881 // View ----------------------------------------------------------------------
877 882
878 // Cache the preferred size of the page in order to prevent sending the IPC 883 // Cache the preferred size of the page in order to prevent sending the IPC
879 // when layout() recomputes but doesn't actually change sizes. 884 // when layout() recomputes but doesn't actually change sizes.
880 gfx::Size preferred_size_; 885 gfx::Size preferred_size_;
881 886
882 // Used to delay determining the preferred size (to avoid intermediate 887 // Used to delay determining the preferred size (to avoid intermediate
883 // states for the sizes). 888 // states for the sizes).
884 base::OneShotTimer check_preferred_size_timer_; 889 base::OneShotTimer check_preferred_size_timer_;
885 890
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
1004 // use the Observer interface to filter IPC messages and receive frame change 1009 // use the Observer interface to filter IPC messages and receive frame change
1005 // notifications. 1010 // notifications.
1006 // --------------------------------------------------------------------------- 1011 // ---------------------------------------------------------------------------
1007 1012
1008 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl); 1013 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
1009 }; 1014 };
1010 1015
1011 } // namespace content 1016 } // namespace content
1012 1017
1013 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 1018 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698