Issue 1399993004: testing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1399993004: testing (Closed)

Created:
5 years, 2 months ago by ssid

Modified:
5 years, 2 months ago

Reviewers:
haraken

CC:
chromium-reviews, blink-reviews, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org, kinuko+watch

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

testing BUG=

Patch Set 1 #

Patch Set 2 : testing. #

Total comments: 1

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
M	third_party/WebKit/Source/core/fetch/MemoryCache.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/fetch/MemoryCache.cpp	View	1	1 chunk	+6 lines, -0 lines	1 comment	Download
M	third_party/WebKit/Source/web/WebKit.cpp	View		3 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

haraken

5 years, 2 months ago (2015-10-14 00:49:01 UTC) #2

https://codereview.chromium.org/1399993004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/MemoryCache.cpp (right):

https://codereview.chromium.org/1399993004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/MemoryCache.cpp:59: *gMemoryCache =
nullptr;

I now realized that this approach won't work... (I should have noticed it
eariler, sorry :-)

One renderer process can be shared among multiple tabs. This means that
gMemoryCache is per-process, not per-tab. Also WebKit::shutdown() can be called
multiple times. If we clear the gMemoryCache in WebKit::shutdown(), it can crash
tabs running on the same renderer process.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages