Issue 1399983003: wstring allocations waste up to 7 wasted bytes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1399983003: wstring allocations waste up to 7 wasted bytes. (Closed)

Created:
5 years, 2 months ago by Tom Sepez

Modified:
5 years, 2 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

wstring allocations waste up to 7 wasted bytes. Consequence of having the same code in two places; fx_basic_bstring.cpp is correct, but fx_basic_wstring.cpp is missing one small change. Noticed while working on 542403, but this will not fix that issue. It is just a space savings. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/6eeffab789800e2afa1b9d10de70c9116db32355

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	core/src/fxcrt/fx_basic_wstring.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Tom Sepez

5 years, 2 months ago (2015-10-13 19:02:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6eeffab789800e2afa1b9d10de70c9116db32355 (presubmit successful).