Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1399983002: [arm64] Fix a string test in StringCompareStub. (Closed)

Created:
5 years, 2 months ago by jbramley
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer, ulan, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm64] Fix a string test in StringCompareStub. This fixes a regression in Octane's pdf.js after r30818. The bug itself has been present for a long time, but StringCompareStub wasn't actually used until r30818 so it went unnoticed. Committed: https://crrev.com/1d9d7821ff792b5d64f6521bf25a19b47067d377 Cr-Commit-Position: refs/heads/master@{#31227}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/arm64/macro-assembler-arm64.cc View 1 chunk +3 lines, -2 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
jbramley
5 years, 2 months ago (2015-10-12 14:15:42 UTC) #2
jbramley
https://codereview.chromium.org/1399983002/diff/1/src/arm64/macro-assembler-arm64.cc File src/arm64/macro-assembler-arm64.cc (right): https://codereview.chromium.org/1399983002/diff/1/src/arm64/macro-assembler-arm64.cc#newcode2429 src/arm64/macro-assembler-arm64.cc:2429: const int kFlatOneByteStringTag = Note that I removed `static` ...
5 years, 2 months ago (2015-10-12 14:16:19 UTC) #3
Benedikt Meurer
LGTM. Thanks for fixing.
5 years, 2 months ago (2015-10-12 17:51:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399983002/1
5 years, 2 months ago (2015-10-13 08:15:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 08:40:39 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 08:40:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d9d7821ff792b5d64f6521bf25a19b47067d377
Cr-Commit-Position: refs/heads/master@{#31227}

Powered by Google App Engine
This is Rietveld 408576698