Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 139993006: Show v8 bleeding edge revision in trunk and Chromium commit message. (Closed)

Created:
6 years, 11 months ago by Michael Achenbach
Modified:
6 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Show v8 bleeding edge revision in trunk and Chromium commit message. This allows to map from a V8 Chromium roll to the bleeding_edge revision used for the roll. This CL also improves some test code: - Don't loose assertion exceptions in mocked git on retry. - Remove an unused method BUG=337167 LOG=n R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18778

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Changed text to "based on bleeding_edge revision". #

Patch Set 3 : Show revision also in Chromium commit message. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -10 lines) Patch
M tools/push-to-trunk/push_to_trunk.py View 1 2 2 chunks +13 lines, -1 line 0 comments Download
M tools/push-to-trunk/test_scripts.py View 1 2 8 chunks +18 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
PTAL
6 years, 11 months ago (2014-01-23 12:46:15 UTC) #1
Jakob Kummerow
LGTM with comment https://codereview.chromium.org/139993006/diff/30001/tools/push-to-trunk/push_to_trunk.py File tools/push-to-trunk/push_to_trunk.py (right): https://codereview.chromium.org/139993006/diff/30001/tools/push-to-trunk/push_to_trunk.py#newcode300 tools/push-to-trunk/push_to_trunk.py:300: "\\1 (V8 revision r%s)" % svn_revision, ...
6 years, 11 months ago (2014-01-23 12:57:35 UTC) #2
Michael Achenbach
https://codereview.chromium.org/139993006/diff/30001/tools/push-to-trunk/push_to_trunk.py File tools/push-to-trunk/push_to_trunk.py (right): https://codereview.chromium.org/139993006/diff/30001/tools/push-to-trunk/push_to_trunk.py#newcode300 tools/push-to-trunk/push_to_trunk.py:300: "\\1 (V8 revision r%s)" % svn_revision, On 2014/01/23 12:57:36, ...
6 years, 11 months ago (2014-01-23 13:02:42 UTC) #3
Jakob Kummerow
lgtm
6 years, 11 months ago (2014-01-23 13:03:41 UTC) #4
Michael Achenbach
6 years, 11 months ago (2014-01-23 13:45:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r18778 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698