Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 1399903002: Allow cross-thread destruction of RTCStatsRequest objects. (Closed)

Created:
5 years, 2 months ago by sof
Modified:
5 years, 2 months ago
Reviewers:
tkent, haraken
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow cross-thread destruction of RTCStatsRequest objects. libjingle threads may in some cases end up finalizing WebRTCStatsRequest objects, deref'ing such objects last via LocalRTCStatsRequest. To allow such cross-thread release of the underlying Blink object, annotate WebRTCStatsRequest's private pointer as cross-thread destructible. R= BUG=541762 Committed: https://crrev.com/ded5273e5572ce8fc7e9871a61ced4e12282681f Cr-Commit-Position: refs/heads/master@{#353642}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/public/platform/WebRTCStatsRequest.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
sof
please take a look. unable to reproduce locally, but the crash report is clear enough ...
5 years, 2 months ago (2015-10-11 06:51:30 UTC) #2
haraken
LGTM
5 years, 2 months ago (2015-10-11 07:53:36 UTC) #3
sof
On 2015/10/11 07:53:36, haraken wrote: > LGTM Thanks (needs public/ approval). LocalRTCStatsResponse does not require ...
5 years, 2 months ago (2015-10-11 16:06:12 UTC) #4
tkent
lgtm
5 years, 2 months ago (2015-10-12 23:09:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399903002/1
5 years, 2 months ago (2015-10-12 23:10:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 00:34:29 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 00:35:21 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ded5273e5572ce8fc7e9871a61ced4e12282681f
Cr-Commit-Position: refs/heads/master@{#353642}

Powered by Google App Engine
This is Rietveld 408576698