Issue 13999008: Remove native_stack accessor from StackedPanelCollection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13999008: Remove native_stack accessor from StackedPanelCollection (Closed)

Created:
7 years, 8 months ago by jianli

Modified:
7 years, 8 months ago

Reviewers:
Dmitry Titov

CC:
chromium-reviews, tfarina, jennb, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove native_stack accessor from StackedPanelCollection We should not try to access native_stack from other classes. In addition, we don't know which one to return if StackedPanelCollection is going to have more than one native stack window in the future. BUG=223155 TEST=existing tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195229

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -7 lines)			Patch
M	chrome/browser/ui/panels/panel_manager.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/panels/stacked_panel_collection.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/panels/stacked_panel_collection.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/panels/panel_stack_view.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jianli

7 years, 8 months ago (2013-04-19 18:09:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r195229 (presubmit successful).

Expand Messages | Collapse Messages