Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: net/quic/quic_framer_test.cc

Issue 1399893005: relnote: Inline all frames smaller than a pointer into QuicFrame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Avoid_redundant_recvmmsg_104327020
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_framer.cc ('k') | net/quic/quic_packet_creator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_framer_test.cc
diff --git a/net/quic/quic_framer_test.cc b/net/quic/quic_framer_test.cc
index 45710c13e3aa9e4205e58c22f7e85cb537170d1c..750f1f36be84a1a9f08ba046ebf22b6c38f24af0 100644
--- a/net/quic/quic_framer_test.cc
+++ b/net/quic/quic_framer_test.cc
@@ -2924,7 +2924,7 @@ TEST_P(QuicFramerTest, BuildPaddingFramePacket) {
QuicPaddingFrame padding_frame;
QuicFrames frames;
- frames.push_back(QuicFrame(&padding_frame));
+ frames.push_back(QuicFrame(padding_frame));
// clang-format off
unsigned char packet[kMaxPacketSize] = {
@@ -2973,7 +2973,7 @@ TEST_P(QuicFramerTest, Build4ByteSequenceNumberPaddingFramePacket) {
QuicPaddingFrame padding_frame;
QuicFrames frames;
- frames.push_back(QuicFrame(&padding_frame));
+ frames.push_back(QuicFrame(padding_frame));
// clang-format off
unsigned char packet[kMaxPacketSize] = {
@@ -3021,7 +3021,7 @@ TEST_P(QuicFramerTest, Build2ByteSequenceNumberPaddingFramePacket) {
QuicPaddingFrame padding_frame;
QuicFrames frames;
- frames.push_back(QuicFrame(&padding_frame));
+ frames.push_back(QuicFrame(padding_frame));
// clang-format off
unsigned char packet[kMaxPacketSize] = {
@@ -3069,7 +3069,7 @@ TEST_P(QuicFramerTest, Build1ByteSequenceNumberPaddingFramePacket) {
QuicPaddingFrame padding_frame;
QuicFrames frames;
- frames.push_back(QuicFrame(&padding_frame));
+ frames.push_back(QuicFrame(padding_frame));
// clang-format off
unsigned char packet[kMaxPacketSize] = {
@@ -3901,7 +3901,7 @@ TEST_P(QuicFramerTest, BuildBlockedPacket) {
blocked_frame.stream_id = 0x01020304;
QuicFrames frames;
- frames.push_back(QuicFrame(&blocked_frame));
+ frames.push_back(QuicFrame(blocked_frame));
// clang-format off
unsigned char packet[] = {
@@ -3944,7 +3944,7 @@ TEST_P(QuicFramerTest, BuildPingPacket) {
QuicPingFrame ping_frame;
QuicFrames frames;
- frames.push_back(QuicFrame(&ping_frame));
+ frames.push_back(QuicFrame(ping_frame));
// clang-format off
unsigned char packet[] = {
@@ -3986,7 +3986,7 @@ TEST_P(QuicFramerTest, BuildMtuDiscoveryPacket) {
QuicMtuDiscoveryFrame mtu_discovery_frame;
QuicFrames frames;
- frames.push_back(QuicFrame(&mtu_discovery_frame));
+ frames.push_back(QuicFrame(mtu_discovery_frame));
// clang-format off
unsigned char packet[] = {
« no previous file with comments | « net/quic/quic_framer.cc ('k') | net/quic/quic_packet_creator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698