relnote: Inline all frames smaller than a pointer into QuicFrame.

net/quic/quic_packet_generator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_packet_generator.h"
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "net/quic/quic_ack_notifier.h"
 #include "net/quic/quic_fec_group.h"
@@ skipping 39 matching lines @@
       should_send_ack_(false),
       should_send_stop_waiting_(false),
       ack_queued_(false),
       stop_waiting_queued_(false),
       max_packet_length_(kDefaultMaxPacketSize) {}
 
 QuicPacketGenerator::~QuicPacketGenerator() {
   for (QuicFrame& frame : queued_control_frames_) {
     switch (frame.type) {
       case PADDING_FRAME:
-        delete frame.padding_frame;
+      case MTU_DISCOVERY_FRAME:
+      case PING_FRAME:
+      case BLOCKED_FRAME:
         break;
       case STREAM_FRAME:
         delete frame.stream_frame;
         break;
       case ACK_FRAME:
         delete frame.ack_frame;
         break;
-      case MTU_DISCOVERY_FRAME:
-        delete frame.mtu_discovery_frame;
-        break;
       case RST_STREAM_FRAME:
         delete frame.rst_stream_frame;
         break;
       case CONNECTION_CLOSE_FRAME:
         delete frame.connection_close_frame;
         break;
       case GOAWAY_FRAME:
         delete frame.goaway_frame;
         break;
       case WINDOW_UPDATE_FRAME:
         delete frame.window_update_frame;
         break;
-      case BLOCKED_FRAME:
-        delete frame.blocked_frame;
-        break;
       case STOP_WAITING_FRAME:
         delete frame.stop_waiting_frame;
         break;
-      case PING_FRAME:
-        delete frame.ping_frame;
-        break;
       case NUM_FRAME_TYPES:
         DCHECK(false) << "Cannot delete type: " << frame.type;
     }
   }
 }
 
 void QuicPacketGenerator::OnCongestionWindowChange(
     QuicPacketCount max_packets_in_flight) {
   packet_creator_.set_max_packets_per_fec_group(
       static_cast<size_t>(kMaxPacketsInFlightMultiplierForFecGroupSize *
@@ skipping 141 matching lines @@
     // The notifier manager will take the ownership of the notifier after the
     // packet is sent.
     ack_notifiers_.push_back(ack_notifier);
   }
 
   const QuicByteCount current_mtu = GetMaxPacketLength();
 
   // The MTU discovery frame is allocated on the stack, since it is going to be
   // serialized within this function.
   QuicMtuDiscoveryFrame mtu_discovery_frame;
-  QuicFrame frame(&mtu_discovery_frame);
+  QuicFrame frame(mtu_discovery_frame);
 
   // Send the probe packet with the new length.
   SetMaxPacketLength(target_mtu, /*force=*/true);
   const bool success = AddFrame(frame, nullptr, /*needs_padding=*/true);
   SerializeAndSendPacket();
   // The only reason AddFrame can fail is that the packet is too full to fit in
   // a ping.  This is not possible for any sane MTU.
   DCHECK(success);
 
   // Reset the packet length back.
@@ skipping 289 matching lines @@
 void QuicPacketGenerator::set_encryption_level(EncryptionLevel level) {
   packet_creator_.set_encryption_level(level);
 }
 
 void QuicPacketGenerator::SetEncrypter(EncryptionLevel level,
                                        QuicEncrypter* encrypter) {
   packet_creator_.SetEncrypter(level, encrypter);
 }
 
 }  // namespace net