Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: pkg/analysis_server/test/analysis/notification_analysis_options_test.dart

Issue 1399893004: Context invalidation on option changes (Implements #24574). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Review fix. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/context_manager.dart ('k') | pkg/analysis_server/test/analysis/test_all.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/analysis/notification_analysis_options_test.dart
diff --git a/pkg/analysis_server/test/analysis/notification_analysis_options_test.dart b/pkg/analysis_server/test/analysis/notification_analysis_options_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..87cc42c942e5289f41259bdc89ea80d3f6954425
--- /dev/null
+++ b/pkg/analysis_server/test/analysis/notification_analysis_options_test.dart
@@ -0,0 +1,167 @@
+// Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+library test.analysis.notification.analysis_options;
+
+import 'package:analysis_server/plugin/protocol/protocol.dart';
+import 'package:analysis_server/src/constants.dart';
+import 'package:analysis_server/src/domain_analysis.dart';
+import 'package:analyzer/src/generated/engine.dart';
+import 'package:test_reflective_loader/test_reflective_loader.dart';
+import 'package:unittest/unittest.dart';
+
+import '../analysis_abstract.dart';
+import '../mocks.dart';
+import '../utils.dart';
+
+main() {
+ initializeTestEnvironment();
+ defineReflectiveTests(AnalysisOptionsFileNotificationTest);
+}
+
+@reflectiveTest
+class AnalysisOptionsFileNotificationTest extends AbstractAnalysisTest {
+ /// Cached model state in case tests need to set task model to on/off.
+ bool wasTaskModelEnabled;
+
+ Map<String, List<AnalysisError>> filesErrors = {};
+
+ final testSource = '''
+main() {
+ var x = '';
+ int y = x; // Not assignable in strong-mode
+ print(y);
+}''';
+
+ List<AnalysisError> get errors => filesErrors[testFile];
+
+ String get optionsFilePath => '$projectPath/.analysis_options';
+
+ AnalysisContext get testContext => server.getContainingContext(testFile);
+
+ void addOptionsFile(String contents) {
+ addFile(optionsFilePath, contents);
+ }
+
+ void deleteFile(String filePath) {
+ resourceProvider.deleteFile(filePath);
+ }
+
+ @override
+ void processNotification(Notification notification) {
+ if (notification.event == ANALYSIS_ERRORS) {
+ var decoded = new AnalysisErrorsParams.fromNotification(notification);
+ filesErrors[decoded.file] = decoded.errors;
+ }
+ }
+
+ void setAnalysisRoot() {
+ Request request =
+ new AnalysisSetAnalysisRootsParams([projectPath], []).toRequest('0');
+ handleSuccessfulRequest(request);
+ }
+
+ void setStrongMode(bool isSet) {
+ addOptionsFile('''
+analyzer:
+ strong-mode: $isSet
+''');
+ }
+
+ @override
+ void setUp() {
+ super.setUp();
+ server.handlers = [new AnalysisDomainHandler(server)];
+ wasTaskModelEnabled = AnalysisEngine.instance.useTaskModel;
+ AnalysisEngine.instance.useTaskModel = true;
+ }
+
+ @override
+ void tearDown() {
+ AnalysisEngine.instance.useTaskModel = wasTaskModelEnabled;
+ super.tearDown();
+ }
+
+ test_options_file_added() async {
+ addTestFile(testSource);
+ setAnalysisRoot();
+
+ await waitForTasksFinished();
+
+ // Verify strong-mode disabled.
+ verifyStrongMode(enabled: false);
+
+ // Clear errors.
+ filesErrors[testFile] = [];
+
+ // Add options file with strong mode enabled.
+ setStrongMode(true);
+
+ await pumpEventQueue();
+ await waitForTasksFinished();
+
+ verifyStrongMode(enabled: true);
+ }
+
+ test_options_file_removed() async {
+ setStrongMode(true);
+
+ addTestFile(testSource);
+ setAnalysisRoot();
+
+ await waitForTasksFinished();
+
+ verifyStrongMode(enabled: true);
+
+ // Clear errors.
+ filesErrors[testFile] = [];
+
+ deleteFile(optionsFilePath);
+
+ await pumpEventQueue();
+ await waitForTasksFinished();
+
+ verifyStrongMode(enabled: false);
+ }
+
+ test_strong_mode_changed() async {
+ setStrongMode(true);
+
+ addTestFile(testSource);
+ setAnalysisRoot();
+
+ await waitForTasksFinished();
+
+ verifyStrongMode(enabled: true);
+
+ // Clear errors.
+ filesErrors[testFile] = [];
+
+ setStrongMode(false);
+
+ await pumpEventQueue();
+ await waitForTasksFinished();
+
+ verifyStrongMode(enabled: false);
+ }
+
+ verifyStrongMode({bool enabled}) {
+ // Verify strong-mode enabled.
+ expect(testContext.analysisOptions.strongMode, enabled);
+
+ if (enabled) {
+ // Should produce a warning and an error.
+ expect(
+ errors.map((error) => error.type),
+ unorderedEquals([
+ AnalysisErrorType.STATIC_TYPE_WARNING,
+ AnalysisErrorType.COMPILE_TIME_ERROR
+ ]));
+ } else {
+ // Should only produce a hint.
+ expect(errors.map((error) => error.type),
+ unorderedEquals([AnalysisErrorType.HINT]));
+ }
+ }
+}
« no previous file with comments | « pkg/analysis_server/lib/src/context_manager.dart ('k') | pkg/analysis_server/test/analysis/test_all.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698