Issue 1399883007: Make //mojo/services/network/interfaces/BUILD.gn reusable by consumers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1399883007: Make //mojo/services/network/interfaces/BUILD.gn reusable by consumers. (Closed)

Created:
5 years, 2 months ago by viettrungluu

Modified:
5 years, 2 months ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/monet.git@master

Target Ref:
refs/heads/master

Project:
monet

Visibility:
Public.

Make //mojo/services/network/interfaces/BUILD.gn reusable by consumers. Turns out all we needed is mojo_sdk_root, which //build/module_args/mojo.gni already has. R=jamesr@chromium.org Committed: https://github.com/domokit/monet0a814ed5512598e595c0ae7975a09d90a7a54e90

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -5 lines)			Patch
	M	mojo/services/network/interfaces/BUILD.gn	View		2 chunks	+3 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

viettrungluu

5 years, 2 months ago (2015-10-13 04:14:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0a814ed5512598e595c0ae7975a09d90a7a54e90 (presubmit successful).