Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1399873002: Issue 24538. Route SDK results into SDK context DartWorkManager. (Closed)

Created:
5 years, 2 months ago by scheglov
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -14 lines) Patch
M pkg/analyzer/lib/file_system/memory_file_system.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 3 chunks +11 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart_work_manager.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analyzer/test/file_system/memory_file_system_test.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 8 chunks +18 lines, -10 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/mock_sdk.dart View 5 chunks +24 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_work_manager_test.dart View 4 chunks +45 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 2 months ago (2015-10-10 04:16:56 UTC) #1
Brian Wilkerson
LGTM
5 years, 2 months ago (2015-10-10 04:38:28 UTC) #2
scheglov
5 years, 2 months ago (2015-10-10 04:45:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ebdfa991d4bef84fda38252ad915609c0b9ca977 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698