content/renderer/render_thread_impl_unittest.cc - Issue 1399853004: Collect separate V8 histograms for Top10 non-Google sites

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_thread_impl_unittest.cc

Issue 1399853004: Collect separate V8 histograms for Top10 non-Google sites (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed UnitTests so they don't need to convert bool Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_thread_impl_unittest.cc

diff --git a/content/renderer/render_thread_impl_unittest.cc b/content/renderer/render_thread_impl_unittest.cc

index 659eba4410ef8f447565d639ce88aca3d93ccbd3..a285b9eb3858e317d3e74b7ef01d87fc525d07be 100644

--- a/content/renderer/render_thread_impl_unittest.cc

+++ b/content/renderer/render_thread_impl_unittest.cc

@@ -80,4 +80,18 @@ TEST_F(RenderThreadImplUnittest, CustomHistogramsForTwoRenderViews) {

kCustomizableHistogram_));

}

+TEST_F(RenderThreadImplUnittest, IdentifyAlexaTop10NonGoogleSite) {

+ EXPECT_TRUE(histogram_customizer_.IsAlexaTop10NonGoogleSite("www.amazon.de"));

+ EXPECT_TRUE(histogram_customizer_.IsAlexaTop10NonGoogleSite("amazon.de"));

+ EXPECT_TRUE(histogram_customizer_.IsAlexaTop10NonGoogleSite("amazon.co.uk"));

+ EXPECT_TRUE(

+ histogram_customizer_.IsAlexaTop10NonGoogleSite("jp.wikipedia.org"));

+ EXPECT_TRUE(

+ histogram_customizer_.IsAlexaTop10NonGoogleSite("www.facebook.com"));

+ EXPECT_FALSE(histogram_customizer_.IsAlexaTop10NonGoogleSite(""));

+ EXPECT_FALSE(

+ histogram_customizer_.IsAlexaTop10NonGoogleSite("www.google.com"));

+ EXPECT_FALSE(histogram_customizer_.IsAlexaTop10NonGoogleSite("madeup"));

} // namespace content

« no previous file with comments | « content/renderer/render_thread_impl.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »