Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 139983007: A64: Indicate the correct size for constant pools. (Closed)

Created:
6 years, 10 months ago by Alexandre Rames
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: Indicate the correct size for constant pools. This fixes potential issues that would appear when trying to insert a breakpoint from JavaScript. Without this, computing the mapping of addresses between versions of the code with and without debug slots could be off by an instruction, trigerring nasty bugs. R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19350

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M src/a64/assembler-a64.cc View 3 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alexandre Rames
6 years, 10 months ago (2014-02-12 13:47:16 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-13 09:22:01 UTC) #2
Alexandre Rames
6 years, 10 months ago (2014-02-13 10:27:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19350 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698