Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: test/mjsunit/regress/regress-1530.js

Issue 139983003: Revert "Make Function.length and Function.name configurable properties." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/mjsunit/harmony/object-observe.js ('k') | test/mjsunit/regress/regress-270142.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 // Verify that the previous redefinition didn't screw up callbacks and 55 // Verify that the previous redefinition didn't screw up callbacks and
56 // the internal value still gets updated. 56 // the internal value still gets updated.
57 var z = { foo: 'other' }; 57 var z = { foo: 'other' };
58 f.prototype = z; 58 f.prototype = z;
59 assertSame(f.prototype, z); 59 assertSame(f.prototype, z);
60 assertSame(f.prototype.foo, 'other'); 60 assertSame(f.prototype.foo, 'other');
61 assertSame(new f().foo, 'other'); 61 assertSame(new f().foo, 'other');
62 assertSame(Object.getPrototypeOf(new f()), z); 62 assertSame(Object.getPrototypeOf(new f()), z);
63 assertSame(Object.getOwnPropertyDescriptor(f, 'prototype').value, z); 63 assertSame(Object.getOwnPropertyDescriptor(f, 'prototype').value, z);
64 64
65 // Verify that 'name' is (initially) non-writable, but configurable.
66 var fname = f.name;
67 f.name = z;
68 assertSame(fname, f.name);
69 Object.defineProperty(f, 'name', {value: 'other'});
70 assertSame('other', f.name);
71
72 // Verify same for 'length', another configurable and non-writable property.
73 assertEquals(0, Object.getOwnPropertyDescriptor(f, 'length').value);
74 assertDoesNotThrow(function () { Object.defineProperty(f, 'length', {writable: t rue}); });
75 f.length = 3;
76 assertEquals(3, Object.getOwnPropertyDescriptor(f, 'length').value);
77 f.length = "untyped";
78 assertSame("untyped", Object.getOwnPropertyDescriptor(f, 'length').value);
79
80 // Verify that non-writability of other properties is respected. 65 // Verify that non-writability of other properties is respected.
66 assertThrows("Object.defineProperty(f, 'name', { value: {} })");
67 assertThrows("Object.defineProperty(f, 'length', { value: {} })");
81 assertThrows("Object.defineProperty(f, 'caller', { value: {} })"); 68 assertThrows("Object.defineProperty(f, 'caller', { value: {} })");
82 assertThrows("Object.defineProperty(f, 'arguments', { value: {} })"); 69 assertThrows("Object.defineProperty(f, 'arguments', { value: {} })");
OLDNEW
« no previous file with comments | « test/mjsunit/harmony/object-observe.js ('k') | test/mjsunit/regress/regress-270142.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698