Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 139983003: Revert "Make Function.length and Function.name configurable properties." (Closed)

Created:
6 years, 10 months ago by rossberg
Modified:
6 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, sof
Visibility:
Public.

Description

Revert "Make Function.length and Function.name configurable properties." Plenty of test failures on test262, Mozilla, Webkit. Will have to investigate. TBR=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19203

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -144 lines) Patch
M src/bootstrapper.cc View 2 chunks +10 lines, -13 lines 0 comments Download
M src/runtime.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M test/cctest/test-accessors.cc View 1 chunk +0 lines, -65 lines 0 comments Download
M test/mjsunit/harmony/object-observe.js View 4 chunks +9 lines, -40 lines 0 comments Download
M test/mjsunit/regress/regress-1530.js View 1 chunk +2 lines, -15 lines 0 comments Download
M test/mjsunit/regress/regress-270142.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-function-length-strict.js View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rossberg
6 years, 10 months ago (2014-02-07 15:28:53 UTC) #1
rossberg
Committed patchset #1 manually as r19203.
6 years, 10 months ago (2014-02-07 15:29:27 UTC) #2
sof
No shortage of test262 failures, e.g., if (delete Date.prototype.toLocaleString.length !== false) { $ERROR(...); } which ...
6 years, 10 months ago (2014-02-08 19:27:56 UTC) #3
rossberg
6 years, 10 months ago (2014-02-10 12:38:00 UTC) #4
Message was sent while issue was closed.
On 2014/02/08 19:27:56, sof wrote:
> No shortage of test262 failures, e.g.,
> 
> if (delete Date.prototype.toLocaleString.length  !== false) {
>   $ERROR(...);
> }
> 
> which you'll find N variations of across many methods on the prototypes of the
> standard objects. Hmm, my bad.
> 
> If putting this behind a flag is worth doing, I could do that. Or it could
just
> wait until ES6 is nigh; it's a small change to make after all.

I'd be fine with a flag, but not sure it's worth it. You would have to provide
separate harmony test cases. Your call. :)

Powered by Google App Engine
This is Rietveld 408576698