Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 13998025: url: Build it as a static library. (Closed)

Created:
7 years, 8 months ago by tfarina
Modified:
7 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, jshin+watch_chromium.org, DaleCurtis, jochen (gone - plz use gerrit), michaeln, Nico
Visibility:
Public.

Description

url: Build it as a static library. This is temporary just to avoid weird link issues in Windows XP. - Update the gyp file. - Rename the gyp file from googleurl.gyp to url.gyp, so it matches the directory name. - Update the header include paths. - Update the header include guards. - Rename the target name from googleurl to url and googleurl_unittests to url_unittests. - Remove GURL_API (this will be replaced by URL_EXPORT when we componentize it again). - Remove url_common.h (will be replaced by url_export.h when we componentize it again). BUG=229660 TEST=url_unittests R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195005

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+648 lines, -716 lines) Patch
D url/googleurl.gyp View 1 chunk +0 lines, -109 lines 0 comments Download
M url/gurl.h View 14 chunks +37 lines, -38 lines 0 comments Download
M url/gurl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M url/gurl_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A url/url.gyp View 1 chunk +99 lines, -0 lines 0 comments Download
M url/url_canon.h View 15 chunks +246 lines, -246 lines 0 comments Download
M url/url_canon_etc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M url/url_canon_filesystemurl.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M url/url_canon_fileurl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M url/url_canon_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M url/url_canon_icu.h View 3 chunks +10 lines, -10 lines 0 comments Download
M url/url_canon_icu.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M url/url_canon_internal.h View 7 chunks +17 lines, -17 lines 0 comments Download
M url/url_canon_internal.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M url/url_canon_internal_file.h View 3 chunks +6 lines, -5 lines 0 comments Download
M url/url_canon_ip.h View 4 chunks +21 lines, -22 lines 0 comments Download
M url/url_canon_ip.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M url/url_canon_mailtourl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M url/url_canon_path.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M url/url_canon_pathurl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M url/url_canon_query.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M url/url_canon_relative.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M url/url_canon_stdstring.h View 2 chunks +6 lines, -6 lines 0 comments Download
M url/url_canon_stdurl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M url/url_canon_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
D url/url_common.h View 1 chunk +0 lines, -54 lines 0 comments Download
M url/url_file.h View 2 chunks +5 lines, -5 lines 0 comments Download
M url/url_parse.h View 9 chunks +55 lines, -56 lines 0 comments Download
M url/url_parse.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M url/url_parse_file.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M url/url_parse_internal.h View 2 chunks +5 lines, -5 lines 0 comments Download
M url/url_parse_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M url/url_test_utils.h View 2 chunks +5 lines, -5 lines 0 comments Download
M url/url_util.h View 10 chunks +63 lines, -64 lines 0 comments Download
M url/url_util.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M url/url_util_internal.h View 2 chunks +4 lines, -5 lines 0 comments Download
M url/url_util_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
Hi Brett, could you review this to me again? Sorry for all the breakages! Jochen, ...
7 years, 8 months ago (2013-04-17 00:27:20 UTC) #1
brettw
lgtm
7 years, 8 months ago (2013-04-17 03:06:07 UTC) #2
tfarina
7 years, 8 months ago (2013-04-18 21:21:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r195005 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698