Issue 13998024: [NaCl SDK] nacl_io: fix warning of macro redefinition on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13998024: [NaCl SDK] nacl_io: fix warning of macro redefinition on Windows. (Closed)

Created:
7 years, 8 months ago by binji

Modified:
7 years, 8 months ago

Reviewers:
Sam Clegg

CC:
chromium-reviews, Sam Clegg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[NaCl SDK] nacl_io: fix warning of macro redefinition on Windows. windows.h defines BEGIN_INTERFACE -- we need to undefine it before we redefine it. BUG=none R=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194632

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -12 lines)			Patch
M	native_client_sdk/src/libraries/nacl_io/pepper_interface.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	native_client_sdk/src/libraries/nacl_io/real_pepper_interface.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	native_client_sdk/src/libraries/nacl_io_test/pepper_interface_mock.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	native_client_sdk/src/libraries/nacl_io_test/pepper_interface_mock.cc	View	4 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

binji

7 years, 8 months ago (2013-04-17 17:57:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r194632 (presubmit successful).