Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 1399783002: Add a hash map for a raw object to id mapping, this table will be used during snapshot writing in o… (Closed)

Created:
5 years, 2 months ago by siva
Modified:
5 years, 2 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a hash map for a raw object to id mapping, this table will be used during snapshot writing in order to map a raw object to an object id. This would enable us to get rid of the current scheme of displacing the object header with the object id while writing a snapshot (requires no GC should be happening while a snapshot is being written and hampers concurrent GC). R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/98cdaecda2d544a9090566d29152f0ee0a59a072

Patch Set 1 #

Patch Set 2 : add-weak-table #

Total comments: 2

Patch Set 3 : code-review-comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -2 lines) Patch
M runtime/vm/heap.h View 2 chunks +12 lines, -0 lines 0 comments Download
M runtime/vm/heap.cc View 1 2 1 chunk +14 lines, -2 lines 0 comments Download
M runtime/vm/weak_table.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/weak_table.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
siva
5 years, 2 months ago (2015-10-09 17:08:39 UTC) #2
Ivan Posva
LGTM -ip https://codereview.chromium.org/1399783002/diff/20001/runtime/vm/heap.cc File runtime/vm/heap.cc (right): https://codereview.chromium.org/1399783002/diff/20001/runtime/vm/heap.cc#newcode651 runtime/vm/heap.cc:651: new_weak_tables_[kHashes]->count() + old_weak_tables_[kHashes]->count(); The line wrapping below ...
5 years, 2 months ago (2015-10-12 09:19:00 UTC) #3
siva
https://codereview.chromium.org/1399783002/diff/20001/runtime/vm/heap.cc File runtime/vm/heap.cc (right): https://codereview.chromium.org/1399783002/diff/20001/runtime/vm/heap.cc#newcode651 runtime/vm/heap.cc:651: new_weak_tables_[kHashes]->count() + old_weak_tables_[kHashes]->count(); On 2015/10/12 09:19:00, Ivan Posva wrote: ...
5 years, 2 months ago (2015-10-12 17:50:19 UTC) #4
siva
5 years, 2 months ago (2015-10-12 18:05:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
98cdaecda2d544a9090566d29152f0ee0a59a072 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698