Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: test/cctest/interpreter/test-bytecode-generator.cc

Issue 1399773002: [Interpreter] Adds logical and, logical or and comma operators to interpreter (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/interpreter/test-bytecode-generator.cc
diff --git a/test/cctest/interpreter/test-bytecode-generator.cc b/test/cctest/interpreter/test-bytecode-generator.cc
index 4b1b9d9b1d380f6fd8f37de7f4edd1b4b72185b9..2df0aef1b86ee75d7243c2cf539167851de24f15 100644
--- a/test/cctest/interpreter/test-bytecode-generator.cc
+++ b/test/cctest/interpreter/test-bytecode-generator.cc
@@ -236,8 +236,7 @@ TEST(PrimitiveExpressions) {
B(Ldar), R(0), //
B(Return) //
},
- 0
- },
+ 0},
{"var x = 0; return x + 3;",
2 * kPointerSize,
1,
@@ -251,8 +250,72 @@ TEST(PrimitiveExpressions) {
B(Add), R(1), //
B(Return) //
},
- 0
- }};
+ 0},
+ {"var x = 0; return (x, 3);",
+ 2 * kPointerSize,
+ 1,
+ 10,
+ {
+ B(LdaZero), //
+ B(Star), R(0), //
+ B(Ldar), R(0), // Easy to spot r1 not really needed here.
+ B(Star), R(1), // Dead store.
+ B(LdaSmi8), U8(3), //
+ B(Return) //
+ },
+ 0},
+ {"var x = 0; return x || 3;",
+ 2 * kPointerSize,
+ 1,
+ 17,
+ {
+ B(LdaZero), //
+ B(Star), R(0), //
+ B(Ldar), R(0), //
+ B(Star), R(1), //
+ B(ToBoolean), //
+ B(JumpIfFalse), U8(6), //
+ B(Ldar), R(1), //
+ B(Jump), U8(4), //
+ B(LdaSmi8), U8(3), //
+ B(Return) //
+ },
+ 0},
+ {"var x = 0; return x && 3;",
+ 2 * kPointerSize,
+ 1,
+ 17,
+ {
+ B(LdaZero), //
+ B(Star), R(0), //
+ B(Ldar), R(0), //
+ B(Star), R(1), //
+ B(ToBoolean), //
+ B(JumpIfTrue), U8(6), //
+ B(Ldar), R(1), //
+ B(Jump), U8(4), //
+ B(LdaSmi8), U8(3), //
+ B(Return) //
+ },
+ 0},
+ {"return 0 && 3;",
+ 1 * kPointerSize,
+ 1,
+ 2,
+ {
+ B(LdaZero), //
+ B(Return) //
+ },
+ 0},
+ {" return 1 || 3;",
+ 1 * kPointerSize,
+ 1,
+ 3,
+ {
+ B(LdaSmi8), U8(1), //
+ B(Return) //
+ },
+ 0}};
for (size_t i = 0; i < arraysize(snippets); i++) {
Handle<BytecodeArray> bytecode_array =

Powered by Google App Engine
This is Rietveld 408576698